You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Damodar Reddy Talakanti <da...@citrix.com> on 2014/04/28 14:38:17 UTC
Review Request 20774: Fixing some minor issues in cloud-setup-databases
script and acs.wxs scripts
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20774/
-----------------------------------------------------------
Review request for cloudstack, Abhinandan Prateek, Frank Zhang, and Murali Reddy.
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6271
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6271
Repository: cloudstack-git
Description
-------
Especially on windows When you install cloud stack at the patch where your path contains white spaces in it then cloud-setup-databases is failing due to the white spaces in the path. Fixed this issue.
Also missed copying python lib to "<Python install path>/Lib/site-packages". Fixed this issue as well.
Diffs
-----
client/pom.xml 5038e66
scripts/installer/windows/acs.wxs f959f1c
setup/bindir/cloud-setup-databases.in dd22e56
Diff: https://reviews.apache.org/r/20774/diff/
Testing
-------
Tested it on windows 2012 R2 server.
Tested python script on linux environment as well for the following 2 cases
1. Having spaces in the path
2. not having spaces in the path.
Thanks,
Damodar Reddy Talakanti
Re: Review Request 20774: Fixing some minor issues in cloud-setup-databases
script and acs.wxs scripts
Posted by Murali Reddy <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20774/#review41699
-----------------------------------------------------------
Ship it!
master 29b4fe6d9f94739c11a368a52cf0122916b1e4d2
- Murali Reddy
On April 28, 2014, 12:38 p.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20774/
> -----------------------------------------------------------
>
> (Updated April 28, 2014, 12:38 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Frank Zhang, and Murali Reddy.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6271
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6271
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Especially on windows When you install cloud stack at the patch where your path contains white spaces in it then cloud-setup-databases is failing due to the white spaces in the path. Fixed this issue.
>
> Also missed copying python lib to "<Python install path>/Lib/site-packages". Fixed this issue as well.
>
>
> Diffs
> -----
>
> client/pom.xml 5038e66
> scripts/installer/windows/acs.wxs f959f1c
> setup/bindir/cloud-setup-databases.in dd22e56
>
> Diff: https://reviews.apache.org/r/20774/diff/
>
>
> Testing
> -------
>
> Tested it on windows 2012 R2 server.
> Tested python script on linux environment as well for the following 2 cases
> 1. Having spaces in the path
> 2. not having spaces in the path.
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>