You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/11/24 09:05:22 UTC
[GitHub] [hudi] manojpec opened a new pull request #4101: [HUDI-2850] Clustering CLI - schedule and run command fixes to avoid NumberFormatException
manojpec opened a new pull request #4101:
URL: https://github.com/apache/hudi/pull/4101
## What is the purpose of the pull request
- Clustering CLI commands schedule and run are passing in arguments in the
wrong order leading to parsing exception. Fixed the same.
- Added sparMaster option to set the host when running the command
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4101: [HUDI-2850] Clustering CLI - schedule and run command fixes to avoid NumberFormatException
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4101:
URL: https://github.com/apache/hudi/pull/4101#issuecomment-979833659
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "698b8813667130390579a89458a3ea8728201c76",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3679",
"triggerID" : "698b8813667130390579a89458a3ea8728201c76",
"triggerType" : "PUSH"
}, {
"hash" : "89112c783ff8dfa373fed8859695f1ecc6912c95",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "89112c783ff8dfa373fed8859695f1ecc6912c95",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 698b8813667130390579a89458a3ea8728201c76 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3679)
* 89112c783ff8dfa373fed8859695f1ecc6912c95 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4101: [HUDI-2850] Clustering CLI - schedule and run command fixes to avoid NumberFormatException
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4101:
URL: https://github.com/apache/hudi/pull/4101#issuecomment-977678442
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "698b8813667130390579a89458a3ea8728201c76",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3679",
"triggerID" : "698b8813667130390579a89458a3ea8728201c76",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 698b8813667130390579a89458a3ea8728201c76 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3679)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4101: [HUDI-2850] Clustering CLI - schedule and run command fixes to avoid NumberFormatException
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4101:
URL: https://github.com/apache/hudi/pull/4101#issuecomment-979835396
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "698b8813667130390579a89458a3ea8728201c76",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3679",
"triggerID" : "698b8813667130390579a89458a3ea8728201c76",
"triggerType" : "PUSH"
}, {
"hash" : "89112c783ff8dfa373fed8859695f1ecc6912c95",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3796",
"triggerID" : "89112c783ff8dfa373fed8859695f1ecc6912c95",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 698b8813667130390579a89458a3ea8728201c76 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3679)
* 89112c783ff8dfa373fed8859695f1ecc6912c95 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3796)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4101: [HUDI-2850] Clustering CLI - schedule and run command fixes to avoid NumberFormatException
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4101:
URL: https://github.com/apache/hudi/pull/4101#issuecomment-979835396
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "698b8813667130390579a89458a3ea8728201c76",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3679",
"triggerID" : "698b8813667130390579a89458a3ea8728201c76",
"triggerType" : "PUSH"
}, {
"hash" : "89112c783ff8dfa373fed8859695f1ecc6912c95",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3796",
"triggerID" : "89112c783ff8dfa373fed8859695f1ecc6912c95",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 698b8813667130390579a89458a3ea8728201c76 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3679)
* 89112c783ff8dfa373fed8859695f1ecc6912c95 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3796)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4101: [HUDI-2850] Clustering CLI - schedule and run command fixes to avoid NumberFormatException
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4101:
URL: https://github.com/apache/hudi/pull/4101#issuecomment-977725541
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "698b8813667130390579a89458a3ea8728201c76",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3679",
"triggerID" : "698b8813667130390579a89458a3ea8728201c76",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 698b8813667130390579a89458a3ea8728201c76 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3679)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4101: [HUDI-2850] Clustering CLI - schedule and run command fixes to avoid NumberFormatException
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4101:
URL: https://github.com/apache/hudi/pull/4101#issuecomment-979886208
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "698b8813667130390579a89458a3ea8728201c76",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3679",
"triggerID" : "698b8813667130390579a89458a3ea8728201c76",
"triggerType" : "PUSH"
}, {
"hash" : "89112c783ff8dfa373fed8859695f1ecc6912c95",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3796",
"triggerID" : "89112c783ff8dfa373fed8859695f1ecc6912c95",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 89112c783ff8dfa373fed8859695f1ecc6912c95 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3796)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #4101: [HUDI-2850] Clustering CLI - schedule and run command fixes to avoid NumberFormatException
Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #4101:
URL: https://github.com/apache/hudi/pull/4101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a change in pull request #4101: [HUDI-2850] Clustering CLI - schedule and run command fixes to avoid NumberFormatException
Posted by GitBox <gi...@apache.org>.
xushiyan commented on a change in pull request #4101:
URL: https://github.com/apache/hudi/pull/4101#discussion_r757161737
##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java
##########
@@ -79,12 +80,14 @@
}
public static void main(String[] args) throws Exception {
- String command = args[0];
- LOG.info("Invoking SparkMain:" + command);
+ final String commandString = args[0];
+ LOG.info("Invoking SparkMain: " + commandString);
+ final SparkCommand cmd = SparkCommand.valueOf(commandString);
- SparkCommand cmd = SparkCommand.valueOf(command);
+ ValidationUtils.checkArgument(args.length >= 4);
Review comment:
can we validate this at the beginning of the method?
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieClusteringJob.java
##########
@@ -59,7 +59,7 @@
public HoodieClusteringJob(JavaSparkContext jsc, Config cfg) {
this.cfg = cfg;
this.jsc = jsc;
- this.props = cfg.propsFilePath == null
+ this.props = (cfg.propsFilePath == null || cfg.propsFilePath.isEmpty())
Review comment:
you can use stringutils here
##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java
##########
@@ -159,33 +162,34 @@ public static void main(String[] args) throws Exception {
case COMPACT_UNSCHEDULE_PLAN:
assert (args.length == 9);
doCompactUnschedule(jsc, args[3], args[4], args[5], Integer.parseInt(args[6]),
- Boolean.parseBoolean(args[7]), Boolean.parseBoolean(args[8]));
+ Boolean.parseBoolean(args[7]), Boolean.parseBoolean(args[8]));
returnCode = 0;
break;
case CLUSTERING_RUN:
- assert (args.length >= 8);
+ assert (args.length >= 9);
propsFilePath = null;
- if (!StringUtils.isNullOrEmpty(args[7])) {
- propsFilePath = args[7];
+ if (!StringUtils.isNullOrEmpty(args[8])) {
+ propsFilePath = args[8];
}
configs = new ArrayList<>();
- if (args.length > 8) {
- configs.addAll(Arrays.asList(args).subList(8, args.length));
+ if (args.length > 9) {
+ configs.addAll(Arrays.asList(args).subList(9, args.length));
}
- returnCode = cluster(jsc, args[1], args[2], args[3], Integer.parseInt(args[4]), args[5],
- Integer.parseInt(args[6]), false, propsFilePath, configs);
+ returnCode = cluster(jsc, args[3], args[4], args[5], Integer.parseInt(args[6]), args[2],
+ Integer.parseInt(args[7]), false, propsFilePath, configs);
Review comment:
do you want to log a ticket for later improvement: this positional argument pretty hard to maintain, can we adopt jcommander here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] manojpec commented on a change in pull request #4101: [HUDI-2850] Clustering CLI - schedule and run command fixes to avoid NumberFormatException
Posted by GitBox <gi...@apache.org>.
manojpec commented on a change in pull request #4101:
URL: https://github.com/apache/hudi/pull/4101#discussion_r757362263
##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/ClusteringCommand.java
##########
@@ -42,12 +42,12 @@
@CliCommand(value = "clustering schedule", help = "Schedule Clustering")
public String scheduleClustering(
Review comment:
Added the java doc.
##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java
##########
@@ -79,12 +80,14 @@
}
public static void main(String[] args) throws Exception {
- String command = args[0];
- LOG.info("Invoking SparkMain:" + command);
+ final String commandString = args[0];
+ LOG.info("Invoking SparkMain: " + commandString);
+ final SparkCommand cmd = SparkCommand.valueOf(commandString);
- SparkCommand cmd = SparkCommand.valueOf(command);
+ ValidationUtils.checkArgument(args.length >= 4);
Review comment:
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4101: [HUDI-2850] Clustering CLI - schedule and run command fixes to avoid NumberFormatException
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4101:
URL: https://github.com/apache/hudi/pull/4101#issuecomment-977675681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "698b8813667130390579a89458a3ea8728201c76",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "698b8813667130390579a89458a3ea8728201c76",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 698b8813667130390579a89458a3ea8728201c76 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4101: [HUDI-2850] Clustering CLI - schedule and run command fixes to avoid NumberFormatException
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4101:
URL: https://github.com/apache/hudi/pull/4101#issuecomment-977678442
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "698b8813667130390579a89458a3ea8728201c76",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3679",
"triggerID" : "698b8813667130390579a89458a3ea8728201c76",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 698b8813667130390579a89458a3ea8728201c76 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3679)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] manojpec commented on a change in pull request #4101: [HUDI-2850] Clustering CLI - schedule and run command fixes to avoid NumberFormatException
Posted by GitBox <gi...@apache.org>.
manojpec commented on a change in pull request #4101:
URL: https://github.com/apache/hudi/pull/4101#discussion_r757362487
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieClusteringJob.java
##########
@@ -59,7 +59,7 @@
public HoodieClusteringJob(JavaSparkContext jsc, Config cfg) {
this.cfg = cfg;
this.jsc = jsc;
- this.props = cfg.propsFilePath == null
+ this.props = (cfg.propsFilePath == null || cfg.propsFilePath.isEmpty())
Review comment:
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] manojpec commented on a change in pull request #4101: [HUDI-2850] Clustering CLI - schedule and run command fixes to avoid NumberFormatException
Posted by GitBox <gi...@apache.org>.
manojpec commented on a change in pull request #4101:
URL: https://github.com/apache/hudi/pull/4101#discussion_r757362723
##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java
##########
@@ -159,33 +162,34 @@ public static void main(String[] args) throws Exception {
case COMPACT_UNSCHEDULE_PLAN:
assert (args.length == 9);
doCompactUnschedule(jsc, args[3], args[4], args[5], Integer.parseInt(args[6]),
- Boolean.parseBoolean(args[7]), Boolean.parseBoolean(args[8]));
+ Boolean.parseBoolean(args[7]), Boolean.parseBoolean(args[8]));
returnCode = 0;
break;
case CLUSTERING_RUN:
- assert (args.length >= 8);
+ assert (args.length >= 9);
propsFilePath = null;
- if (!StringUtils.isNullOrEmpty(args[7])) {
- propsFilePath = args[7];
+ if (!StringUtils.isNullOrEmpty(args[8])) {
+ propsFilePath = args[8];
}
configs = new ArrayList<>();
- if (args.length > 8) {
- configs.addAll(Arrays.asList(args).subList(8, args.length));
+ if (args.length > 9) {
+ configs.addAll(Arrays.asList(args).subList(9, args.length));
}
- returnCode = cluster(jsc, args[1], args[2], args[3], Integer.parseInt(args[4]), args[5],
- Integer.parseInt(args[6]), false, propsFilePath, configs);
+ returnCode = cluster(jsc, args[3], args[4], args[5], Integer.parseInt(args[6]), args[2],
+ Integer.parseInt(args[7]), false, propsFilePath, configs);
Review comment:
sure, will file a ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4101: [HUDI-2850] Clustering CLI - schedule and run command fixes to avoid NumberFormatException
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4101:
URL: https://github.com/apache/hudi/pull/4101#issuecomment-977675681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "698b8813667130390579a89458a3ea8728201c76",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "698b8813667130390579a89458a3ea8728201c76",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 698b8813667130390579a89458a3ea8728201c76 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4101: [HUDI-2850] Clustering CLI - schedule and run command fixes to avoid NumberFormatException
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4101:
URL: https://github.com/apache/hudi/pull/4101#issuecomment-977725541
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "698b8813667130390579a89458a3ea8728201c76",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3679",
"triggerID" : "698b8813667130390579a89458a3ea8728201c76",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 698b8813667130390579a89458a3ea8728201c76 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3679)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4101: [HUDI-2850] Clustering CLI - schedule and run command fixes to avoid NumberFormatException
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4101:
URL: https://github.com/apache/hudi/pull/4101#issuecomment-979833659
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "698b8813667130390579a89458a3ea8728201c76",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3679",
"triggerID" : "698b8813667130390579a89458a3ea8728201c76",
"triggerType" : "PUSH"
}, {
"hash" : "89112c783ff8dfa373fed8859695f1ecc6912c95",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "89112c783ff8dfa373fed8859695f1ecc6912c95",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 698b8813667130390579a89458a3ea8728201c76 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3679)
* 89112c783ff8dfa373fed8859695f1ecc6912c95 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #4101: [HUDI-2850] Clustering CLI - schedule and run command fixes to avoid NumberFormatException
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #4101:
URL: https://github.com/apache/hudi/pull/4101#discussion_r756351048
##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/ClusteringCommand.java
##########
@@ -42,12 +42,12 @@
@CliCommand(value = "clustering schedule", help = "Schedule Clustering")
public String scheduleClustering(
Review comment:
can you add a java doc here w/ an example command
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #4101: [HUDI-2850] Clustering CLI - schedule and run command fixes to avoid NumberFormatException
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4101:
URL: https://github.com/apache/hudi/pull/4101#issuecomment-979937279
Please file a tracking ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org