You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/02/08 07:29:18 UTC

[GitHub] sijie commented on a change in pull request #1129: WIP Upgrade JaCoCo and Upgrade Coveralls.io configuration

sijie commented on a change in pull request #1129: WIP Upgrade JaCoCo and Upgrade Coveralls.io configuration
URL: https://github.com/apache/bookkeeper/pull/1129#discussion_r166849508
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -389,6 +389,9 @@
                 <groupId>org.eluder.coveralls</groupId>
                 <artifactId>coveralls-maven-plugin</artifactId>
                 <version>4.3.0</version>
+                <configuration>
+                    <sourceDirectories>circe-checksum/target/nar/nar-generated</sourceDirectories>
 
 Review comment:
   Understand what sourcediectories mean. My question is why do we need to test coverage for generated code. I don?t see a reason to cover generated code, unless I missed anything.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services