You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/10/10 06:10:59 UTC
[GitHub] [hudi] codecov-io commented on pull request #2158: [MINOR]Optimization for Option
codecov-io commented on pull request #2158:
URL: https://github.com/apache/hudi/pull/2158#issuecomment-706495289
# [Codecov](https://codecov.io/gh/apache/hudi/pull/2158?src=pr&el=h1) Report
> Merging [#2158](https://codecov.io/gh/apache/hudi/pull/2158?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hudi/commit/a86f5574ed68333f03165ae560a4d88812ba7478?el=desc) will **decrease** coverage by `6.25%`.
> The diff coverage is `33.33%`.
[](https://codecov.io/gh/apache/hudi/pull/2158?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2158 +/- ##
============================================
- Coverage 59.86% 53.61% -6.26%
+ Complexity 4322 2846 -1476
============================================
Files 552 359 -193
Lines 22930 16537 -6393
Branches 2314 1778 -536
============================================
- Hits 13727 8866 -4861
+ Misses 8195 6913 -1282
+ Partials 1008 758 -250
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| #hudicli | `38.37% <ø> (-27.65%)` | `193.00 <ø> (-1579.00)` | |
| #hudiclient | `100.00% <ø> (+25.59%)` | `0.00 <ø> (-1579.00)` | :arrow_up: |
| #hudicommon | `54.73% <33.33%> (-0.07%)` | `1794.00 <4.00> (+89.00)` | :arrow_down: |
| #hudihadoopmr | `33.05% <ø> (ø)` | `181.00 <ø> (ø)` | |
| #hudispark | `65.51% <ø> (-1.66%)` | `303.00 <ø> (-7.00)` | |
| #huditimelineservice | `62.29% <ø> (-1.19%)` | `50.00 <ø> (+3.00)` | :arrow_down: |
| #hudiutilities | `69.98% <ø> (+0.66%)` | `325.00 <ø> (+18.00)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/hudi/pull/2158?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../main/java/org/apache/hudi/common/util/Option.java](https://codecov.io/gh/apache/hudi/pull/2158/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3V0aWwvT3B0aW9uLmphdmE=) | `66.66% <33.33%> (-3.61%)` | `23.00 <4.00> (+1.00)` | :arrow_down: |
| [...n/java/org/apache/hudi/internal/DefaultSource.java](https://codecov.io/gh/apache/hudi/pull/2158/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pbnRlcm5hbC9EZWZhdWx0U291cmNlLmphdmE=) | `0.00% <0.00%> (-80.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pache/hudi/internal/HoodieWriterCommitMessage.java](https://codecov.io/gh/apache/hudi/pull/2158/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pbnRlcm5hbC9Ib29kaWVXcml0ZXJDb21taXRNZXNzYWdlLmphdmE=) | `83.33% <0.00%> (-16.67%)` | `2.00% <0.00%> (-1.00%)` | |
| [...a/org/apache/hudi/common/util/CollectionUtils.java](https://codecov.io/gh/apache/hudi/pull/2158/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3V0aWwvQ29sbGVjdGlvblV0aWxzLmphdmE=) | `11.53% <0.00%> (-15.39%)` | `3.00% <0.00%> (-2.00%)` | |
| [.../hudi/internal/HoodieDataSourceInternalWriter.java](https://codecov.io/gh/apache/hudi/pull/2158/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pbnRlcm5hbC9Ib29kaWVEYXRhU291cmNlSW50ZXJuYWxXcml0ZXIuamF2YQ==) | `78.12% <0.00%> (-8.98%)` | `6.00% <0.00%> (-2.00%)` | |
| [...n/scala/org/apache/hudi/HoodieSparkSqlWriter.scala](https://codecov.io/gh/apache/hudi/pull/2158/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2h1ZGkvSG9vZGllU3BhcmtTcWxXcml0ZXIuc2NhbGE=) | `51.14% <0.00%> (-3.76%)` | `0.00% <0.00%> (ø%)` | |
| [...common/table/view/AbstractTableFileSystemView.java](https://codecov.io/gh/apache/hudi/pull/2158/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3ZpZXcvQWJzdHJhY3RUYWJsZUZpbGVTeXN0ZW1WaWV3LmphdmE=) | `83.33% <0.00%> (-2.72%)` | `133.00% <0.00%> (+28.00%)` | :arrow_down: |
| [.../apache/hudi/timeline/service/TimelineService.java](https://codecov.io/gh/apache/hudi/pull/2158/diff?src=pr&el=tree#diff-aHVkaS10aW1lbGluZS1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RpbWVsaW5lL3NlcnZpY2UvVGltZWxpbmVTZXJ2aWNlLmphdmE=) | `25.00% <0.00%> (-2.54%)` | `6.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...udi/utilities/sources/helpers/DFSPathSelector.java](https://codecov.io/gh/apache/hudi/pull/2158/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvaGVscGVycy9ERlNQYXRoU2VsZWN0b3IuamF2YQ==) | `82.05% <0.00%> (-2.16%)` | `12.00% <0.00%> (ø%)` | |
| [...di/common/table/timeline/HoodieActiveTimeline.java](https://codecov.io/gh/apache/hudi/pull/2158/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL0hvb2RpZUFjdGl2ZVRpbWVsaW5lLmphdmE=) | `73.73% <0.00%> (-1.92%)` | `40.00% <0.00%> (ø%)` | |
| ... and [240 more](https://codecov.io/gh/apache/hudi/pull/2158/diff?src=pr&el=tree-more) | |
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org