You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/10 09:17:34 UTC
[GitHub] [spark] MaxGekk opened a new pull request, #37464: [SPARK-40008][SQL][FOLLOWUP] Fix codegen of casting integrals to ANSI intervals
MaxGekk opened a new pull request, #37464:
URL: https://github.com/apache/spark/pull/37464
### What changes were proposed in this pull request?
This is a follow up of https://github.com/apache/spark/pull/37442 that fixes the codegen of casting integrals to ANSI intervals w/ multi units. The PR removes the assert:
```scala
assert(it.startField == it.endField)
```
### Why are the changes needed?
To make codegen consistent to interpreted code, and fix the assert.
### Does this PR introduce _any_ user-facing change?
Yes.
Before:
```sql
> select cast(dt as interval hour to second) from values(100Y) as t(dt);
java.lang.AssertionError
assertion failed
```
After:
```sql
> select cast(dt as interval hour to second) from values(100Y) as t(dt);
0 00:01:40.000000000
```
### How was this patch tested?
By running new tests:
```
$ build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite -- -z cast.sql"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #37464: [SPARK-40008][SQL][FOLLOWUP] Fix codegen of casting integrals to ANSI intervals
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #37464: [SPARK-40008][SQL][FOLLOWUP] Fix codegen of casting integrals to ANSI intervals
URL: https://github.com/apache/spark/pull/37464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #37464: [SPARK-40008][SQL][FOLLOWUP] Fix codegen of casting integrals to ANSI intervals
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #37464:
URL: https://github.com/apache/spark/pull/37464#issuecomment-1210563580
The failure of `ImageFileFormatSuite` is not related to the changes. @HyukjinKwon @cloud-fan @gengliangwang Could you take a look at the PR, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #37464: [SPARK-40008][SQL][FOLLOWUP] Fix codegen of casting integrals to ANSI intervals
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #37464:
URL: https://github.com/apache/spark/pull/37464#issuecomment-1210779505
Merging to master. Thank you, @cloud-fan for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org