[jira] [Commented] (HBASE-9816) Address review comments in HBASE-8496

["ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-9816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13807914#comment-13807914 ] 

ramkrishna.s.vasudevan commented on HBASE-9816:
-----------------------------------------------

[~saint.ack@gmail.com]
Wrt to the comments on the short for the tag length and byte for the tag type
We thought that it 256 types for the tag type should be ok.  Also using Vint in the KV infrastructure will not allow us to create a KV from the buffers as every time we are not sure on the size of the KV.  If the Tag  had been an inmemory structure then using Vint would have been ideal.  

So for now the internal format I am not changing in this review.  Is it fine Stack?  
This discussion is in line with one of the review comments from Stack
bq.twobyte long tag seems a little gratuitous.  One byte not enough?  Could type and length be combined in two bytes with top couple of bits for type and remainder for length?  256 types and Short.MAX_SIZE for tag length seems overkill

> Address review comments in HBASE-8496
> -------------------------------------
>
>                 Key: HBASE-9816
>                 URL: https://issues.apache.org/jira/browse/HBASE-9816
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.98.0
>
>
> This JIRA would be used to address the review comments in HBASE-8496.  Any more comments would be addressed and committed as part of this.  There are already few comments from Stack on the RB.
> https://reviews.apache.org/r/13311/



--
This message was sent by Atlassian JIRA
(v6.1#6144)