You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2026/06/21 17:54:29 UTC
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
shacharya@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24489
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
IMPALA-14997: Set EnvironmentContext for Iceberg
Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
---
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/24489/1
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 12:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/23011/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 12
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jun 2026 13:02:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 8:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/22994/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 8
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Jun 2026 17:54:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/22948/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 21 Jun 2026 18:18:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 20:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/23415/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 20
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Jul 2026 10:26:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24489
to look at the new patch set (#2).
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
IMPALA-14997: Set EnvironmentContext for Iceberg
Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
---
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/24489/2
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 5:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/22988/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Jun 2026 14:50:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24489
to look at the new patch set (#5).
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
IMPALA-14997: Set EnvironmentContext for Iceberg
Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
---
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M tests/query_test/test_iceberg.py
2 files changed, 27 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/24489/5
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 5:
(10 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/24489/5/fe/src/main/java/org/apache/impala/util/IcebergUtil.java
File fe/src/main/java/org/apache/impala/util/IcebergUtil.java:
http://gerrit.cloudera.org:8080/#/c/24489/5/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@1906
PS5, Line 1906: envContext.putToProperties("engine.version", BackendConfig.INSTANCE.getImpalaBuildVersion());
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/24489/5/tests/query_test/test_iceberg.py
File tests/query_test/test_iceberg.py:
http://gerrit.cloudera.org:8080/#/c/24489/5/tests/query_test/test_iceberg.py@2853
PS5, Line 2853: d
flake8: E301 expected 1 blank line, found 0
http://gerrit.cloudera.org:8080/#/c/24489/5/tests/query_test/test_iceberg.py@2857
PS5, Line 2857:
flake8: W291 trailing whitespace
http://gerrit.cloudera.org:8080/#/c/24489/5/tests/query_test/test_iceberg.py@2857
PS5, Line 2857: CREATE TABLE {0}.{1} (id INT)
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/24489/5/tests/query_test/test_iceberg.py@2860
PS5, Line 2860:
flake8: W293 blank line contains whitespace
http://gerrit.cloudera.org:8080/#/c/24489/5/tests/query_test/test_iceberg.py@2860
PS5, Line 2860:
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/24489/5/tests/query_test/test_iceberg.py@2866
PS5, Line 2866:
flake8: W293 blank line contains whitespace
http://gerrit.cloudera.org:8080/#/c/24489/5/tests/query_test/test_iceberg.py@2866
PS5, Line 2866:
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/24489/5/tests/query_test/test_iceberg.py@2868
PS5, Line 2868: m
flake8: E501 line too long (95 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/24489/5/tests/query_test/test_iceberg.py@2869
PS5, Line 2869: t
flake8: E501 line too long (95 > 90 characters)
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Jun 2026 14:40:58 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24489
to look at the new patch set (#7).
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
IMPALA-14997: Set EnvironmentContext for Iceberg
Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Sets the catalog environment context properties (engine name and engine
version) for Iceberg operations. This ensures that downstream catalogs
and metastores can correctly track Impala as the processing engine.
Testing:
- Extended test_iceberg.py with a dedicated test case to assert that
'engine.name' and 'engine.version' are correctly written to the
metadata properties.
- Ran frontend unit tests to ensure compatibility.
---
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M tests/query_test/test_iceberg.py
2 files changed, 31 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/24489/7
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 7
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24489
to look at the new patch set (#17).
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
IMPALA-14997: Set EnvironmentContext for Iceberg
Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Sets the catalog environment context properties (engine name and engine
version) for Iceberg operations. This ensures that downstream catalogs
and metastores can correctly track Impala as the processing engine.
Testing:
- Extended test_iceberg.py with a dedicated test case to assert that
'engine.name' and 'engine.version' are correctly written to the
metadata properties.
- Ran frontend unit tests to ensure compatibility.
---
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M tests/query_test/test_iceberg.py
3 files changed, 31 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/24489/17
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 17
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 16:
(1 comment)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/24489/16/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java
File fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java:
http://gerrit.cloudera.org:8080/#/c/24489/16/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java@66
PS16, Line 66: // Inject the engine and version details straight into the table
line has trailing whitespace
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 16
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Jul 2026 15:52:39 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24489
to look at the new patch set (#19).
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
IMPALA-14997: Set EnvironmentContext for Iceberg
Sets the catalog environment context properties (engine name and engine
version) for Iceberg operations. This ensures that downstream catalogs
and metastores can correctly track Impala as the processing engine.
Testing:
- Extended test_iceberg.py with a dedicated test case to assert that
'engine.name' and 'engine.version' are correctly written to the
metadata properties.
- Ran frontend unit tests to ensure compatibility.
Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
---
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M tests/query_test/test_iceberg.py
3 files changed, 33 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/24489/19
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 19
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 20:
(2 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/24489/20/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java
File fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java:
http://gerrit.cloudera.org:8080/#/c/24489/20/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java@67
PS20, Line 67: // Inject the engine and version details straight into the table creation properties map
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/24489/20/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java@72
PS20, Line 72: return IcebergHadoopCatalog.class.getName().equals("") ? null : hadoopCatalog.createTable(
line too long (94 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 20
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Jul 2026 10:03:06 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24489
to look at the new patch set (#13).
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
IMPALA-14997: Set EnvironmentContext for Iceberg
Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Sets the catalog environment context properties (engine name and engine
version) for Iceberg operations. This ensures that downstream catalogs
and metastores can correctly track Impala as the processing engine.
Testing:
- Extended test_iceberg.py with a dedicated test case to assert that
'engine.name' and 'engine.version' are correctly written to the
metadata properties.
- Ran frontend unit tests to ensure compatibility.
---
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M tests/query_test/test_iceberg.py
2 files changed, 25 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/24489/13
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 13
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 21:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/23417/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 21
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Jul 2026 10:48:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 3:
(2 comments)
Thanks for working on this.
http://gerrit.cloudera.org:8080/#/c/24489/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/24489/3//COMMIT_MSG@8
PS3, Line 8:
Please write description for the commit.
Also add a section about testing. Before that, please add/extend tests in test_iceberg.py that verify that the metadata is written correctly.
http://gerrit.cloudera.org:8080/#/c/24489/3/fe/src/main/java/org/apache/impala/util/IcebergUtil.java
File fe/src/main/java/org/apache/impala/util/IcebergUtil.java:
http://gerrit.cloudera.org:8080/#/c/24489/3/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@1479
PS3, Line 1479: "4.4.0"
Latest released version is 4.5.0. Anyway, please use BackendConfig.INSTANCE.getImpalaBuildVersion() instead of a hard-wired constant.
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Jun 2026 12:48:57 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 7:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/22989/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 7
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Jun 2026 14:56:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 9:
(3 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/24489/9/tests/query_test/test_iceberg.py
File tests/query_test/test_iceberg.py:
http://gerrit.cloudera.org:8080/#/c/24489/9/tests/query_test/test_iceberg.py@2853
PS9, Line 2853:
flake8: W293 blank line contains whitespace
http://gerrit.cloudera.org:8080/#/c/24489/9/tests/query_test/test_iceberg.py@2853
PS9, Line 2853:
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/24489/9/tests/query_test/test_iceberg.py@2869
PS9, Line 2869:
flake8: W292 no newline at end of file
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 9
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jun 2026 08:32:07 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 14:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/23016/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 14
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jun 2026 16:17:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 10:
(6 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/24489/10/tests/query_test/test_iceberg.py
File tests/query_test/test_iceberg.py:
http://gerrit.cloudera.org:8080/#/c/24489/10/tests/query_test/test_iceberg.py@2853
PS10, Line 2853:
flake8: W293 blank line contains whitespace
http://gerrit.cloudera.org:8080/#/c/24489/10/tests/query_test/test_iceberg.py@2853
PS10, Line 2853:
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/24489/10/tests/query_test/test_iceberg.py@2857
PS10, Line 2857: t
flake8: E501 line too long (110 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/24489/10/tests/query_test/test_iceberg.py@2863
PS10, Line 2863: e
flake8: E501 line too long (99 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/24489/10/tests/query_test/test_iceberg.py@2864
PS10, Line 2864: t
flake8: E501 line too long (95 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/24489/10/tests/query_test/test_iceberg.py@2864
PS10, Line 2864:
flake8: W292 no newline at end of file
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 10
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jun 2026 08:37:52 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 9:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/23007/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 9
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jun 2026 08:40:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 15:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/23107/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 15
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Jul 2026 17:26:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 15:
(2 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/24489/15/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java
File fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java:
http://gerrit.cloudera.org:8080/#/c/24489/15/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java@66
PS15, Line 66: // Inject the engine and version details straight into the table creation properties map
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/24489/15/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java@72
PS15, Line 72: return class_getName().equals("") ? null : hadoopCatalog.createTable(identifier, schema, spec, /*location=*/null,
line too long (117 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 15
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Jul 2026 17:17:53 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/22950/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 21 Jun 2026 18:40:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 4:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/22987/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Jun 2026 14:35:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 11:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/23010/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 11
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jun 2026 10:31:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24489
to look at the new patch set (#15).
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
IMPALA-14997: Set EnvironmentContext for Iceberg
Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Sets the catalog environment context properties (engine name and engine
version) for Iceberg operations. This ensures that downstream catalogs
and metastores can correctly track Impala as the processing engine.
Testing:
- Extended test_iceberg.py with a dedicated test case to assert that
'engine.name' and 'engine.version' are correctly written to the
metadata properties.
- Ran frontend unit tests to ensure compatibility.
---
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M tests/query_test/test_iceberg.py
3 files changed, 28 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/24489/15
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 15
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 16:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/23395/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 16
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Jul 2026 16:02:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24489
to look at the new patch set (#16).
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
IMPALA-14997: Set EnvironmentContext for Iceberg
Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Sets the catalog environment context properties (engine name and engine
version) for Iceberg operations. This ensures that downstream catalogs
and metastores can correctly track Impala as the processing engine.
Testing:
- Extended test_iceberg.py with a dedicated test case to assert that
'engine.name' and 'engine.version' are correctly written to the
metadata properties.
- Ran frontend unit tests to ensure compatibility.
---
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M tests/query_test/test_iceberg.py
3 files changed, 31 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/24489/16
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 16
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 1:
(1 comment)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/24489/1/fe/src/main/java/org/apache/impala/util/IcebergUtil.java
File fe/src/main/java/org/apache/impala/util/IcebergUtil.java:
http://gerrit.cloudera.org:8080/#/c/24489/1/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@1477
PS1, Line 1477: props.put(org.apache.iceberg.EnvironmentContext.ENGINE_VERSION, System.getProperty("impala.version", "4.4.0"));
line too long (115 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 21 Jun 2026 17:57:00 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24489
to look at the new patch set (#8).
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
IMPALA-14997: Set EnvironmentContext for Iceberg
Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Sets the catalog environment context properties (engine name and engine
version) for Iceberg operations. This ensures that downstream catalogs
and metastores can correctly track Impala as the processing engine.
Testing:
- Extended test_iceberg.py with a dedicated test case to assert that
'engine.name' and 'engine.version' are correctly written to the
metadata properties.
- Ran frontend unit tests to ensure compatibility.
---
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M tests/query_test/test_iceberg.py
2 files changed, 32 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/24489/8
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 8
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24489
to look at the new patch set (#12).
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
IMPALA-14997: Set EnvironmentContext for Iceberg
Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Sets the catalog environment context properties (engine name and engine
version) for Iceberg operations. This ensures that downstream catalogs
and metastores can correctly track Impala as the processing engine.
Testing:
- Extended test_iceberg.py with a dedicated test case to assert that
'engine.name' and 'engine.version' are correctly written to the
metadata properties.
- Ran frontend unit tests to ensure compatibility.
---
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M tests/query_test/test_iceberg.py
2 files changed, 24 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/24489/12
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 12
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24489
to look at the new patch set (#9).
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
IMPALA-14997: Set EnvironmentContext for Iceberg
Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Sets the catalog environment context properties (engine name and engine
version) for Iceberg operations. This ensures that downstream catalogs
and metastores can correctly track Impala as the processing engine.
Testing:
- Extended test_iceberg.py with a dedicated test case to assert that
'engine.name' and 'engine.version' are correctly written to the
metadata properties.
- Ran frontend unit tests to ensure compatibility.
---
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M tests/query_test/test_iceberg.py
2 files changed, 29 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/24489/9
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 9
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 19:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/23412/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 19
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Jul 2026 09:11:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24489
to look at the new patch set (#21).
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
IMPALA-14997: Set EnvironmentContext for Iceberg
Sets the catalog environment context properties (engine name and engine
version) for Iceberg operations. This ensures that downstream catalogs
and metastores can correctly track Impala as the processing engine.
Testing:
- Extended test_iceberg.py with a dedicated test case to assert that
'engine.name' and 'engine.version' are correctly written to the
metadata properties.
- Ran frontend unit tests to ensure compatibility.
Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
---
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M tests/query_test/test_iceberg.py
3 files changed, 38 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/24489/21
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 21
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/22949/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 21 Jun 2026 18:33:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24489
to look at the new patch set (#11).
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
IMPALA-14997: Set EnvironmentContext for Iceberg
Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Sets the catalog environment context properties (engine name and engine
version) for Iceberg operations. This ensures that downstream catalogs
and metastores can correctly track Impala as the processing engine.
Testing:
- Extended test_iceberg.py with a dedicated test case to assert that
'engine.name' and 'engine.version' are correctly written to the
metadata properties.
- Ran frontend unit tests to ensure compatibility.
---
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M tests/query_test/test_iceberg.py
2 files changed, 31 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/24489/11
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 11
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24489
to look at the new patch set (#4).
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
IMPALA-14997: Set EnvironmentContext for Iceberg
Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
---
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/24489/4
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24489
to look at the new patch set (#6).
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
IMPALA-14997: Set EnvironmentContext for Iceberg
Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Sets the catalog environment context properties (engine name and engine
version) for Iceberg operations. This ensures that downstream catalogs
and metastores can correctly track Impala as the processing engine.
Testing:
- Extended test_iceberg.py with a dedicated test case to assert that
'engine.name' and 'engine.version' are correctly written to the
metadata properties.
- Ran frontend unit tests to ensure compatibility.
---
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M tests/query_test/test_iceberg.py
2 files changed, 27 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/24489/6
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24489
to look at the new patch set (#10).
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
IMPALA-14997: Set EnvironmentContext for Iceberg
Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Sets the catalog environment context properties (engine name and engine
version) for Iceberg operations. This ensures that downstream catalogs
and metastores can correctly track Impala as the processing engine.
Testing:
- Extended test_iceberg.py with a dedicated test case to assert that
'engine.name' and 'engine.version' are correctly written to the
metadata properties.
- Ran frontend unit tests to ensure compatibility.
---
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M tests/query_test/test_iceberg.py
2 files changed, 24 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/24489/10
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 10
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 17:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/23397/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 17
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Jul 2026 16:07:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24489
to look at the new patch set (#20).
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
IMPALA-14997: Set EnvironmentContext for Iceberg
Sets the catalog environment context properties (engine name and engine
version) for Iceberg operations. This ensures that downstream catalogs
and metastores can correctly track Impala as the processing engine.
Testing:
- Extended test_iceberg.py with a dedicated test case to assert that
'engine.name' and 'engine.version' are correctly written to the
metadata properties.
- Ran frontend unit tests to ensure compatibility.
Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
---
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M tests/query_test/test_iceberg.py
3 files changed, 33 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/24489/20
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 20
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 12:
(2 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/24489/12/tests/query_test/test_iceberg.py
File tests/query_test/test_iceberg.py:
http://gerrit.cloudera.org:8080/#/c/24489/12/tests/query_test/test_iceberg.py@2857
PS12, Line 2857: t
flake8: E501 line too long (103 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/24489/12/tests/query_test/test_iceberg.py@2864
PS12, Line 2864:
flake8: W391 blank line at end of file
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 12
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jun 2026 12:54:07 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 10:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/23008/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 10
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jun 2026 08:46:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 13:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/23012/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 13
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jun 2026 13:24:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 13:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/24489/13//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/24489/13//COMMIT_MSG@9
PS13, Line 9: Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
This should be at the end.
http://gerrit.cloudera.org:8080/#/c/24489/13//COMMIT_MSG@12
PS13, Line 12:
Fix the redundant whitespaces and end of lines.
http://gerrit.cloudera.org:8080/#/c/24489/13/fe/src/main/java/org/apache/impala/util/IcebergUtil.java
File fe/src/main/java/org/apache/impala/util/IcebergUtil.java:
http://gerrit.cloudera.org:8080/#/c/24489/13/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@1476
PS13, Line 1476: props.put(org.apache.iceberg.EnvironmentContext.ENGINE_NAME,
Other engines set the EnvironmentContext: https://github.com/apache/iceberg/blob/6976e020b894f6a6777704df2b8c4458cb291ae9/spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java#L734
This method might also not the best to set these static configs.
http://gerrit.cloudera.org:8080/#/c/24489/13/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@1479
PS13, Line 1479: 4.4.0
Still an old Impala version being hardcoded here.
http://gerrit.cloudera.org:8080/#/c/24489/13/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@1903
PS13, Line 1903: setIcebergEngineContext
It's never getting invoked.
http://gerrit.cloudera.org:8080/#/c/24489/13/tests/query_test/test_iceberg.py
File tests/query_test/test_iceberg.py:
http://gerrit.cloudera.org:8080/#/c/24489/13/tests/query_test/test_iceberg.py@2864
PS13, Line 2864: assert properties.get('engine.name') == 'impala'
We should also verify that metadata queries return these fields, e.g. they should be in the summary column:
select * from unique_database.engine_context_preset_test.snapshots;
http://gerrit.cloudera.org:8080/#/c/24489/13/tests/query_test/test_iceberg.py@2865
PS13, Line 2865: properties
We should verify that it is the current version, i.e. use os.getenv("IMPALA_VERSION")
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 13
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jun 2026 14:58:12 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 7:
(3 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/24489/7/tests/query_test/test_iceberg.py
File tests/query_test/test_iceberg.py:
http://gerrit.cloudera.org:8080/#/c/24489/7/tests/query_test/test_iceberg.py@2853
PS7, Line 2853:
flake8: W293 blank line contains whitespace
http://gerrit.cloudera.org:8080/#/c/24489/7/tests/query_test/test_iceberg.py@2853
PS7, Line 2853:
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/24489/7/tests/query_test/test_iceberg.py@2871
PS7, Line 2871:
flake8: W292 no newline at end of file
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 7
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Jun 2026 14:47:53 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 8:
(5 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/24489/8/tests/query_test/test_iceberg.py
File tests/query_test/test_iceberg.py:
http://gerrit.cloudera.org:8080/#/c/24489/8/tests/query_test/test_iceberg.py@2853
PS8, Line 2853:
flake8: W293 blank line contains whitespace
http://gerrit.cloudera.org:8080/#/c/24489/8/tests/query_test/test_iceberg.py@2853
PS8, Line 2853:
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/24489/8/tests/query_test/test_iceberg.py@2872
PS8, Line 2872:
flake8: W293 blank line contains whitespace
http://gerrit.cloudera.org:8080/#/c/24489/8/tests/query_test/test_iceberg.py@2872
PS8, Line 2872:
flake8: W292 no newline at end of file
http://gerrit.cloudera.org:8080/#/c/24489/8/tests/query_test/test_iceberg.py@2872
PS8, Line 2872:
line has trailing whitespace
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 8
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Jun 2026 17:46:04 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24489
to look at the new patch set (#14).
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
IMPALA-14997: Set EnvironmentContext for Iceberg
Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Sets the catalog environment context properties (engine name and engine
version) for Iceberg operations. This ensures that downstream catalogs
and metastores can correctly track Impala as the processing engine.
Testing:
- Extended test_iceberg.py with a dedicated test case to assert that
'engine.name' and 'engine.version' are correctly written to the
metadata properties.
- Ran frontend unit tests to ensure compatibility.
---
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M tests/query_test/test_iceberg.py
3 files changed, 29 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/24489/14
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 14
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 4:
(1 comment)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/24489/4/fe/src/main/java/org/apache/impala/util/IcebergUtil.java
File fe/src/main/java/org/apache/impala/util/IcebergUtil.java:
http://gerrit.cloudera.org:8080/#/c/24489/4/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@1906
PS4, Line 1906: envContext.putToProperties("engine.version", BackendConfig.INSTANCE.getImpalaBuildVersion());
line too long (101 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Jun 2026 14:27:20 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 2:
(1 comment)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/24489/2/fe/src/main/java/org/apache/impala/util/IcebergUtil.java
File fe/src/main/java/org/apache/impala/util/IcebergUtil.java:
http://gerrit.cloudera.org:8080/#/c/24489/2/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@1477
PS2, Line 1477: props.put(org.apache.iceberg.EnvironmentContext.ENGINE_VERSION, System.getProperty("impala.version", "4.4.0"));
line too long (115 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 21 Jun 2026 18:11:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24489
to look at the new patch set (#3).
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
IMPALA-14997: Set EnvironmentContext for Iceberg
Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
---
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/24489/3
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24489
to look at the new patch set (#18).
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
IMPALA-14997: Set EnvironmentContext for Iceberg
Sets the catalog environment context properties (engine name and engine
version) for Iceberg operations. This ensures that downstream catalogs
and metastores can correctly track Impala as the processing engine.
Testing:
- Extended test_iceberg.py with a dedicated test case to assert that
'engine.name' and 'engine.version' are correctly written to the
metadata properties.
- Ran frontend unit tests to ensure compatibility.
Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
---
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M tests/query_test/test_iceberg.py
3 files changed, 31 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/24489/18
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 18
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14997: Set EnvironmentContext for Iceberg
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg
......................................................................
Patch Set 18:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/23398/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/24489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2
Gerrit-Change-Number: 24489
Gerrit-PatchSet: 18
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Jul 2026 16:39:42 +0000
Gerrit-HasComments: No