You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/05/16 21:08:12 UTC
[kudu-CR] KUDU-1294 fix issue with unreleased consumption
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6901
Change subject: KUDU-1294 fix issue with unreleased consumption
......................................................................
KUDU-1294 fix issue with unreleased consumption
In DEBUG builds, the DCHECK assert on unreleased consumption fires
time to time in the destructor of MemTracker objects. The root was
found by Todd and described in the first comment on KUDU-1294. This
patch fixes the issue by re-ordering the sequence of removing the
transaction driver from the map and releasing its memory consumption.
As a test, I ran 1K+ iterations of security-faults-itest test built
in DEBUG configuration with --stress-cpu-threads=8. Prior to this fix,
usually ~15 out of 1024 run were failing due to the issue:
http://dist-test.cloudera.org//job?job_id=aserbin.1494966417.6076
After the fix, there were not any failures in the whole 1K run:
http://dist-test.cloudera.org//job?job_id=aserbin.1494963982.18117
Change-Id: I41d4fd4c0030af02ae5b1e83bd52833632ed6743
---
M src/kudu/tablet/transactions/transaction_tracker.cc
1 file changed, 7 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/6901/1
--
To view, visit http://gerrit.cloudera.org:8080/6901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I41d4fd4c0030af02ae5b1e83bd52833632ed6743
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] KUDU-1294 fix issue with unreleased consumption
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: KUDU-1294 fix issue with unreleased consumption
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41d4fd4c0030af02ae5b1e83bd52833632ed6743
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-1294 fix issue with unreleased consumption
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: KUDU-1294 fix issue with unreleased consumption
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6901/1//COMMIT_MSG
Commit Message:
Line 10: time to time in the destructor of MemTracker objects. The root was
> Nit: from time to time
Done
--
To view, visit http://gerrit.cloudera.org:8080/6901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41d4fd4c0030af02ae5b1e83bd52833632ed6743
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1294 fix issue with unreleased consumption
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#2).
Change subject: KUDU-1294 fix issue with unreleased consumption
......................................................................
KUDU-1294 fix issue with unreleased consumption
In DEBUG builds, the DCHECK assert on unreleased consumption fires
from time to time in the destructor of MemTracker objects. The root
cause was found by Todd and described in the first comment on KUDU-1294.
This patch fixes the issue by re-ordering the sequence of removing the
transaction driver from the map and releasing its memory consumption.
As a test, I ran 1K+ iterations of security-faults-itest test built
in DEBUG configuration with --stress-cpu-threads=8. Prior to this fix,
usually ~15 out of 1024 tests were failing due to the issue:
http://dist-test.cloudera.org//job?job_id=aserbin.1494966417.6076
After the fix, there were not any failures in the whole 1K run:
http://dist-test.cloudera.org//job?job_id=aserbin.1494963982.18117
Change-Id: I41d4fd4c0030af02ae5b1e83bd52833632ed6743
---
M src/kudu/tablet/transactions/transaction_tracker.cc
1 file changed, 7 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/6901/2
--
To view, visit http://gerrit.cloudera.org:8080/6901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I41d4fd4c0030af02ae5b1e83bd52833632ed6743
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-1294 fix issue with unreleased consumption
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: KUDU-1294 fix issue with unreleased consumption
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6901/1//COMMIT_MSG
Commit Message:
Line 10: time to time in the destructor of MemTracker objects. The root was
Nit: from time to time
Also, "root cause"
--
To view, visit http://gerrit.cloudera.org:8080/6901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41d4fd4c0030af02ae5b1e83bd52833632ed6743
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1294 fix issue with unreleased consumption
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: KUDU-1294 fix issue with unreleased consumption
......................................................................
KUDU-1294 fix issue with unreleased consumption
In DEBUG builds, the DCHECK assert on unreleased consumption fires
from time to time in the destructor of MemTracker objects. The root
cause was found by Todd and described in the first comment on KUDU-1294.
This patch fixes the issue by re-ordering the sequence of removing the
transaction driver from the map and releasing its memory consumption.
As a test, I ran 1K+ iterations of security-faults-itest test built
in DEBUG configuration with --stress-cpu-threads=8. Prior to this fix,
usually ~15 out of 1024 tests were failing due to the issue:
http://dist-test.cloudera.org//job?job_id=aserbin.1494966417.6076
After the fix, there were not any failures in the whole 1K run:
http://dist-test.cloudera.org//job?job_id=aserbin.1494963982.18117
Change-Id: I41d4fd4c0030af02ae5b1e83bd52833632ed6743
Reviewed-on: http://gerrit.cloudera.org:8080/6901
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/tablet/transactions/transaction_tracker.cc
1 file changed, 7 insertions(+), 12 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I41d4fd4c0030af02ae5b1e83bd52833632ed6743
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>