You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2005/06/22 16:49:34 UTC
[Bug 4420] New: If a rule has no score, _handle_hit() blows up
http://bugzilla.spamassassin.org/show_bug.cgi?id=4420
Summary: If a rule has no score, _handle_hit() blows up
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Platform: Other
OS/Version: other
Status: NEW
Severity: normal
Priority: P5
Component: Libraries
AssignedTo: dev@spamassassin.apache.org
ReportedBy: jbrunette@excel.net
SpamAssassin 3.1.0pre1.
I'm not sure if this is a case of "well, just make sure your rules have scores"
or if SA should be updated to gracefully warn or otherwise handle it.
If a rule hits but has no score, PerMsgStatus::handle_hit() passes an undefined
$score to _handle_hit(), which blows up attempting to use it as a number,
generating about 20 "Use of uninitialized value in..." errors.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4420] If a rule has no score, _handle_hit() blows up
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4420
jbrunette@excel.net changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |INVALID
------- Additional Comments From jbrunette@excel.net 2005-06-22 10:39 -------
I'm marking this INVALID. I noticed that the only time these errors appeared
was when there were many spamds running (20+, etc) in a testing environment.
When _handle_hit() generated errors, the message being scanned at the time had
EMPTY_MESSAGE and TO_CC_NONE hits when they should not have. My guess is that
somehow the high load is corrupting SA in some way.
I was not able to reproduce this under "normal" circumstances.
FYI: Fedora Core 4, perl 5.8.6, two processors.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4420] If a rule has no score, _handle_hit() blows up
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4420
------- Additional Comments From felicity@apache.org 2005-06-22 09:07 -------
Subject: Re: New: If a rule has no score, _handle_hit() blows up
On Wed, Jun 22, 2005 at 07:49:34AM -0700, bugzilla-daemon@bugzilla.spamassassin.org wrote:
> I'm not sure if this is a case of "well, just make sure your rules have scores"
> or if SA should be updated to gracefully warn or otherwise handle it.
IMO, that's pretty much it. The Conf system makes sure all rules have a score
before anything gets processed, so the case of a rule w/ no score should never
occur.
> If a rule hits but has no score, PerMsgStatus::handle_hit() passes an undefined
> $score to _handle_hit(), which blows up attempting to use it as a number,
> generating about 20 "Use of uninitialized value in..." errors.
It probably shouldn't do that anyway, but I also don't like checking for cases
that should never happen because of checking earlier in the code.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4420] If a rule has no score, _handle_hit() blows up
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4420
------- Additional Comments From felicity@apache.org 2005-06-22 11:29 -------
Subject: Re: If a rule has no score, _handle_hit() blows up
On Wed, Jun 22, 2005 at 09:46:43AM -0700, bugzilla-daemon@bugzilla.spamassassin.org wrote:
> what's the situation in which you can get a rule to have no score, without Conf
> noticing?
If you're directly using the modules you could just add a rule without a
config at all. There shouldn't be any way to do this just using the normal
spamassassin/spamd scripts.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4420] If a rule has no score, _handle_hit() blows up
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4420
------- Additional Comments From jm@jmason.org 2005-06-22 09:46 -------
what's the situation in which you can get a rule to have no score, without Conf
noticing?
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.