You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2016/08/28 19:22:55 UTC
[kudu-CR] cfile: replace DumpIteratorOptions with number of rows
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4150
to review the following change.
Change subject: cfile: replace DumpIteratorOptions with number of rows
......................................................................
cfile: replace DumpIteratorOptions with number of rows
As of commit 9884fab, DumpIterator() doesn't print anything at all when
print_rows is false. That makes the option rather useless, so I'm replacing
it here with the raw number of rows.
Change-Id: I5d9e80e50926a71d22de4f88a7af6a8091bb2063
---
M src/kudu/cfile/cfile-dump.cc
M src/kudu/cfile/cfile_util.cc
M src/kudu/cfile/cfile_util.h
M src/kudu/tools/fs_tool.cc
4 files changed, 27 insertions(+), 52 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/4150/1
--
To view, visit http://gerrit.cloudera.org:8080/4150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d9e80e50926a71d22de4f88a7af6a8091bb2063
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] cfile: replace DumpIteratorOptions with number of rows
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: cfile: replace DumpIteratorOptions with number of rows
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/3114/
--
To view, visit http://gerrit.cloudera.org:8080/4150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d9e80e50926a71d22de4f88a7af6a8091bb2063
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] cfile: replace DumpIteratorOptions with number of rows
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: cfile: replace DumpIteratorOptions with number of rows
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4150/1/src/kudu/cfile/cfile-dump.cc
File src/kudu/cfile/cfile-dump.cc:
Line 31: DEFINE_int32(num_iterations, 1, "number of times to iterate the file");
the original reason to have --noprint_rows not print anything was so that this tool could be used for benchmarking raw read performance of a cfile, which also explains num_iterations. I agree that we have better (and more relevant) benchmarks now, but let's also get rid of num_iterations while we're at it
http://gerrit.cloudera.org:8080/#/c/4150/1/src/kudu/cfile/cfile_util.h
File src/kudu/cfile/cfile_util.h:
Line 86: int num_rows,
do we actually use this other than with 0?
--
To view, visit http://gerrit.cloudera.org:8080/4150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d9e80e50926a71d22de4f88a7af6a8091bb2063
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] cfile: replace DumpIteratorOptions with number of rows
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: cfile: replace DumpIteratorOptions with number of rows
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4150/1/src/kudu/cfile/cfile-dump.cc
File src/kudu/cfile/cfile-dump.cc:
Line 31: DEFINE_int32(num_iterations, 1, "number of times to iterate the file");
> the original reason to have --noprint_rows not print anything was so that t
Yep, the next patch in this series gets rid of it.
http://gerrit.cloudera.org:8080/#/c/4150/1/src/kudu/cfile/cfile_util.h
File src/kudu/cfile/cfile_util.h:
Line 86: int num_rows,
> do we actually use this other than with 0?
kudu-fs_dump-tool allows users to customize it via FLAGS_nrows. That hasn't been ported to the new tool, but I imagine the flag will survive when it is.
--
To view, visit http://gerrit.cloudera.org:8080/4150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d9e80e50926a71d22de4f88a7af6a8091bb2063
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] cfile: replace DumpIteratorOptions with number of rows
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: cfile: replace DumpIteratorOptions with number of rows
......................................................................
Patch Set 2:
Build Started http://104.196.14.100/job/kudu-gerrit/3121/
--
To view, visit http://gerrit.cloudera.org:8080/4150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d9e80e50926a71d22de4f88a7af6a8091bb2063
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] cfile: replace DumpIteratorOptions with number of rows
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: cfile: replace DumpIteratorOptions with number of rows
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d9e80e50926a71d22de4f88a7af6a8091bb2063
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] cfile: replace DumpIteratorOptions with number of rows
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: cfile: replace DumpIteratorOptions with number of rows
......................................................................
cfile: replace DumpIteratorOptions with number of rows
As of commit 9884fab, DumpIterator() doesn't print anything at all when
print_rows is false. That makes the option rather useless, so I'm replacing
it here with the raw number of rows.
Change-Id: I5d9e80e50926a71d22de4f88a7af6a8091bb2063
Reviewed-on: http://gerrit.cloudera.org:8080/4150
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/cfile/cfile-dump.cc
M src/kudu/cfile/cfile_util.cc
M src/kudu/cfile/cfile_util.h
M src/kudu/tools/fs_tool.cc
4 files changed, 27 insertions(+), 52 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d9e80e50926a71d22de4f88a7af6a8091bb2063
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>