You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/19 13:05:13 UTC
[GitHub] [shardingsphere-elasticjob] terrymanu opened a new issue #1610: Move OneOffJobBootstrap.triggerAllInstances into InstanceService
terrymanu opened a new issue #1610:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1610
There are too details export to public area, it is better to move it into internal service.
Tasks are:
- [ ] Move OneOffJobBootstrap.triggerAllInstances into InstanceService
- [ ] Remove getter of JobScheduler.regCenter and JobScheduler.jobConfig
- [ ] Add test case
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] terrymanu closed issue #1610: Move OneOffJobBootstrap.triggerAllInstances into InstanceService
Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #1610:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1610
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] wwj-go commented on issue #1610: Move OneOffJobBootstrap.triggerAllInstances into InstanceService
Posted by GitBox <gi...@apache.org>.
wwj-go commented on issue #1610:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1610#issuecomment-713238444
hi @terrymanu @TeslaCN , can we add a construct method in `OneOffJobBootstrap `just for test？
```
@com.google.common.annotations.VisibleForTesting
OneOffJobBootstrap() {
jobScheduler = null;
instanceService = null;
}
```
As you see,it is package-private.
For the existing two construction methods, it hard to construct the instance for OneOffJobBootstrap when write a test case, because the parameter `CoordinatorRegistryCenter regCenter`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] terrymanu commented on issue #1610: Move OneOffJobBootstrap.triggerAllInstances into InstanceService
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #1610:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1610#issuecomment-713378121
It is better to do not add a constructor for test only
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] wwj-go commented on issue #1610: Move OneOffJobBootstrap.triggerAllInstances into InstanceService
Posted by GitBox <gi...@apache.org>.
wwj-go commented on issue #1610:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1610#issuecomment-712147621
please assign it to me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org