You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/08/05 22:59:26 UTC
[GitHub] [incubator-mxnet] barry-jin opened a new pull request #20490: [DOC][v2.0] Part3: Evaluate Notebooks
barry-jin opened a new pull request #20490:
URL: https://github.com/apache/incubator-mxnet/pull/20490
## Description ##
Part3 of documentation fixes. Will be included in v2.0.0 beta release #19139
Evaluate notebooks.
## Checklist ##
### Essentials ###
- [x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage
- [x] Code is well-documented
### Changes ###
- [x] Run notebook evaluation on gpu
- [x] User can add any flaky notebooks into skip_list in md2ipynb.py
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20490: [DOC][v2.0] Part3: Evaluate Notebooks
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20490:
URL: https://github.com/apache/incubator-mxnet/pull/20490#issuecomment-899637270
@mxnet-bot run ci [centos-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20490: [DOC][v2.0] Part3: Evaluate Notebooks
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20490:
URL: https://github.com/apache/incubator-mxnet/pull/20490#issuecomment-898095300
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20490: [DOC][v2.0] Part3: Evaluate Notebooks
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20490:
URL: https://github.com/apache/incubator-mxnet/pull/20490#issuecomment-895661545
Jenkins CI successfully triggered : [edge, centos-cpu, clang, sanity, centos-gpu, miscellaneous, website, unix-gpu, windows-cpu, windows-gpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin merged pull request #20490: [DOC][v2.0] Part3: Evaluate Notebooks
Posted by GitBox <gi...@apache.org>.
barry-jin merged pull request #20490:
URL: https://github.com/apache/incubator-mxnet/pull/20490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20490: [DOC][v2.0] Part3: Evaluate Notebooks
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20490:
URL: https://github.com/apache/incubator-mxnet/pull/20490#issuecomment-899637350
Jenkins CI successfully triggered : [centos-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20490: [DOC][v2.0] Part3: Evaluate Notebooks
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20490:
URL: https://github.com/apache/incubator-mxnet/pull/20490#issuecomment-899240143
Jenkins CI successfully triggered : [centos-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20490: [DOC][v2.0] Part3: Evaluate Notebooks
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20490:
URL: https://github.com/apache/incubator-mxnet/pull/20490#issuecomment-898095344
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on a change in pull request #20490: [DOC][v2.0] Part3: Evaluate Notebooks
Posted by GitBox <gi...@apache.org>.
barry-jin commented on a change in pull request #20490:
URL: https://github.com/apache/incubator-mxnet/pull/20490#discussion_r688834544
##########
File path: docs/python_docs/python/tutorials/packages/np/cheat-sheet.md
##########
@@ -90,7 +90,7 @@ npx.load('my_array')
```{.python .input}
# Save a list of arrays
b = np.array([4, 6, 8])
-npx.save('my_arrays', [a, b]) # FIXME, cannot be a tuple
+npx.savez('my_arrays', *[a, b]) # FIXME, cannot be a tuple
Review comment:
Not relevant. Let me remove the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20490: [DOC][v2.0] Part3: Evaluate Notebooks
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20490:
URL: https://github.com/apache/incubator-mxnet/pull/20490#issuecomment-893873303
Hey @barry-jin , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [centos-cpu, website, windows-gpu, centos-gpu, edge, miscellaneous, unix-gpu, sanity, unix-cpu, windows-cpu, clang]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on a change in pull request #20490: [DOC][v2.0] Part3: Evaluate Notebooks
Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #20490:
URL: https://github.com/apache/incubator-mxnet/pull/20490#discussion_r688833379
##########
File path: docs/python_docs/python/tutorials/packages/np/cheat-sheet.md
##########
@@ -90,7 +90,7 @@ npx.load('my_array')
```{.python .input}
# Save a list of arrays
b = np.array([4, 6, 8])
-npx.save('my_arrays', [a, b]) # FIXME, cannot be a tuple
+npx.savez('my_arrays', *[a, b]) # FIXME, cannot be a tuple
Review comment:
Is this comment still relevant?
##########
File path: docs/python_docs/python/scripts/md2ipynb.py
##########
@@ -26,17 +26,28 @@ def md2ipynb():
(src_fn, input_fn, output_fn) = sys.argv
# timeout for each notebook, in sec
- timeout = 20 * 60
+ timeout = 60 * 60
# if enable evaluation
do_eval = int(os.environ.get('EVAL', True))
+
+ # Skip these notebooks as some APIs will no longer be used
+ skip_list = ["pytorch.md", "mnist.md", "custom-loss.md", "fit_api_tutorial.md", \
+ "01-ndarray-intro.md", "02-ndarray-operations.md", "03-ndarray-contexts.md", \
+ "gotchas_numpy_in_mxnet.md", "csr.md", "row_sparse.md", "fine_tuning_gluon.md", \
+ "inference_on_onnx_model.md", "amp.md", "profiler.md"]
Review comment:
Let's create an issue to track them in case some is still applicable in 2.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20490: [DOC][v2.0] Part3: Evaluate Notebooks
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20490:
URL: https://github.com/apache/incubator-mxnet/pull/20490#issuecomment-895661507
@mxnet-bot run ci [all]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin merged pull request #20490: [DOC][v2.0] Part3: Evaluate Notebooks
Posted by GitBox <gi...@apache.org>.
barry-jin merged pull request #20490:
URL: https://github.com/apache/incubator-mxnet/pull/20490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20490: [DOC][v2.0] Part3: Evaluate Notebooks
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20490:
URL: https://github.com/apache/incubator-mxnet/pull/20490#issuecomment-899883650
@mxnet-bot run ci [centos-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20490: [DOC][v2.0] Part3: Evaluate Notebooks
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20490:
URL: https://github.com/apache/incubator-mxnet/pull/20490#issuecomment-899240107
@mxnet-bot run ci [centos-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20490: [DOC][v2.0] Part3: Evaluate Notebooks
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20490:
URL: https://github.com/apache/incubator-mxnet/pull/20490#issuecomment-899883686
Jenkins CI successfully triggered : [centos-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org