You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "Croway (via GitHub)" <gi...@apache.org> on 2023/04/20 15:17:04 UTC
[GitHub] [camel] Croway opened a new pull request, #9906: Use jakarta API in ITs
Croway opened a new pull request, #9906:
URL: https://github.com/apache/camel/pull/9906
Generated DTOs will be generated without timestamp since swagger-codegen does not fully support jakarta yet.
Should we use openapi codegen maven plugin instead of swagger?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #9906: Use jakarta API in ITs
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #9906:
URL: https://github.com/apache/camel/pull/9906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9906: Use jakarta API in ITs
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9906:
URL: https://github.com/apache/camel/pull/9906#issuecomment-1516897959
:no_entry_sign: There are (likely) no components to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a diff in pull request #9906: Use jakarta API in ITs
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on code in PR #9906:
URL: https://github.com/apache/camel/pull/9906#discussion_r1172968305
##########
tooling/maven/camel-restdsl-openapi-plugin/src/main/java/org/apache/camel/maven/generator/openapi/AbstractGenerateMojo.java:
##########
@@ -214,13 +214,21 @@ void generateDto(final String language) throws MojoExecutionException {
if (modelWithXml != null) {
elements.add(new MojoExecutor.Element("withXml", modelWithXml));
}
- if (configOptions != null) {
- elements.add(new MojoExecutor.Element(
- "configOptions", configOptions.entrySet().stream()
- .map(e -> new MojoExecutor.Element(e.getKey(), e.getValue()))
- .toArray(MojoExecutor.Element[]::new)));
+ if (configOptions == null) {
+ configOptions = new HashMap<>(1);
}
-
+ /* workaround for https://github.com/swagger-api/swagger-codegen/issues/11797
+ * with the next release jakarta=true should be used
+ * https://github.com/swagger-api/swagger-codegen-generators/pull/1131
+ */
+ configOptions.put("hideGenerationTimestamp", "true");
+ elements.add(new MojoExecutor.Element(
+ "configOptions", configOptions.entrySet().stream()
+ .map(e -> new MojoExecutor.Element(e.getKey(), e.getValue()))
+ .toArray(MojoExecutor.Element[]::new)));
+
+
+ System.out.println(elements.toArray(new MojoExecutor.Element[0]));
Review Comment:
Should this system out be there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9906: Use jakarta API in ITs
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9906:
URL: https://github.com/apache/camel/pull/9906#issuecomment-1516621289
:no_entry_sign: There are (likely) no components to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #9906: Use jakarta API in ITs
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #9906:
URL: https://github.com/apache/camel/pull/9906#issuecomment-1516520815
I think we should move to openapi codegen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org