You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/05/20 13:51:52 UTC

[GitHub] [trafficcontrol] ocket8888 opened a new pull request #3586: Angular 7

ocket8888 opened a new pull request #3586: Angular 7
URL: https://github.com/apache/trafficcontrol/pull/3586
 
 
   ## What does this PR (Pull Request) do?
   - [x] This PR is not related to any Issue
   
   Includes an update to the dashboard that includes links on each DS "card" to a details page, URL updates as search progresses, making a search linkable directly by copying the page URL (previously you needed to manually edit it to include the `search` query param - this now happens automatically as you type). It also reduces memory usage on the dashboard by about 70 to 80%.
   
   The DS details page is now fully-functional with a breakdown of TPS data for a DS (at the edge tier) as well as bandwidth for both edge- and mid-tiers. Data range can be adjusted with date/time controls at the top of the page.
   
   Also includes bug fixes on the server side - it used to crash when connections were dropped before requests could be fully received/fulfilled.
   
   ## Which Traffic Control components are affected by this PR?
   `experimental/traffic-portal-angular7` - no docs b/c experimental
   
   ## What is the best way to verify this PR?
   It comes with (low-coverage) unit and end-to-end tests. As the README explains, these can be run with `ng test` and `ng e2e`, respectively.
   
   ## The following criteria are ALL met by this PR
   - [x] This PR includes tests
   - [x]  I have explained why documentation is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services