You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "maskit (via GitHub)" <gi...@apache.org> on 2023/03/15 22:11:28 UTC
[GitHub] [trafficserver] maskit opened a new pull request, #9524: Link boringocsp lib to UDP unit test
maskit opened a new pull request, #9524:
URL: https://github.com/apache/trafficserver/pull/9524
I'm not sure why only this test is affected, but I saw a link issue when I run `make check` where I build ATS with boringocsp library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #9524: Link boringocsp lib to unit tests
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on PR #9524:
URL: https://github.com/apache/trafficserver/pull/9524#issuecomment-1492580214
@maskit This has a trivial merge conflict on 9.2.1, I can fix it easily, unless you want to make a 9.2.x PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #9524: Link boringocsp lib to unit tests
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on PR #9524:
URL: https://github.com/apache/trafficserver/pull/9524#issuecomment-1520954403
Removed from 9.2.x project as we are dropping ocspboring support and the library has never been open-sourced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on a diff in pull request #9524: Link boringocsp lib to unit tests
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on code in PR #9524:
URL: https://github.com/apache/trafficserver/pull/9524#discussion_r1140653838
##########
iocore/cache/Makefile.am:
##########
@@ -116,6 +116,7 @@ test_LDADD = \
@LIBPROFILER@ \
@OPENSSL_LIBS@ \
@YAMLCPP_LIBS@ \
+ @BORINGOCSP_LIBS@ \
Review Comment:
The spacing of this line seems inconsistent with the ones before it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit merged pull request #9524: Link boringocsp lib to unit tests
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit merged PR #9524:
URL: https://github.com/apache/trafficserver/pull/9524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org