You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Jukka Zitting (JIRA)" <ji...@apache.org> on 2007/01/19 14:50:29 UTC
[jira] Created: (JCR-714) TCK: Test root path not escaped when used
in XPath queries
TCK: Test root path not escaped when used in XPath queries
----------------------------------------------------------
Key: JCR-714
URL: https://issues.apache.org/jira/browse/JCR-714
Project: Jackrabbit
Issue Type: Bug
Components: JCR TCK
Reporter: Jukka Zitting
Priority: Minor
A repository implementation might use a test root path that contains names that need _xXXXX_ escaping when used in XPath queries. Currently the TCK just uses the test path as-is when constructing queries. Even though this only affects few repositories (I've heard of one legacy connector to run into this problem), it would be good to add the proper escaping.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (JCR-714) TCK: Test root path not escaped when used
in XPath queries
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-714:
------------------------------
Attachment: JCR-714.patch
Attached a patch that properly encodes the test path for use in the XPath queries.
The only problem with this patch is that it needs the ISO9075.encodePath() method from jackrabbit-jcr-commons. I'm not sure what are the implications of the jcr-commons dependency, though as long as the TCK webapp uses JNDI to access the repository from another classloader this should be no problem.
> TCK: Test root path not escaped when used in XPath queries
> ----------------------------------------------------------
>
> Key: JCR-714
> URL: https://issues.apache.org/jira/browse/JCR-714
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr-tests
> Reporter: Jukka Zitting
> Priority: Minor
> Attachments: JCR-714.patch
>
>
> A repository implementation might use a test root path that contains names that need _xXXXX_ escaping when used in XPath queries. Currently the TCK just uses the test path as-is when constructing queries. Even though this only affects few repositories (I've heard of one legacy connector to run into this problem), it would be good to add the proper escaping.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-714) TCK: Test root path not escaped when used
in XPath queries
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-714:
------------------------------
Status: Patch Available (was: Open)
> TCK: Test root path not escaped when used in XPath queries
> ----------------------------------------------------------
>
> Key: JCR-714
> URL: https://issues.apache.org/jira/browse/JCR-714
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-jcr-tests
> Reporter: Jukka Zitting
> Priority: Minor
> Attachments: JCR-714.patch
>
>
> A repository implementation might use a test root path that contains names that need _xXXXX_ escaping when used in XPath queries. Currently the TCK just uses the test path as-is when constructing queries. Even though this only affects few repositories (I've heard of one legacy connector to run into this problem), it would be good to add the proper escaping.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-714) TCK: Test root path not escaped when used
in XPath queries
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-714:
------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0
Assignee: Jukka Zitting
Status: Resolved (was: Patch Available)
Patch applied in revision 792118.
Instead of introducing the jcr-commons dependency, I copied the required support classes to o.a.j.test.api.util.
> TCK: Test root path not escaped when used in XPath queries
> ----------------------------------------------------------
>
> Key: JCR-714
> URL: https://issues.apache.org/jira/browse/JCR-714
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-jcr-tests
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: JCR-714.patch
>
>
> A repository implementation might use a test root path that contains names that need _xXXXX_ escaping when used in XPath queries. Currently the TCK just uses the test path as-is when constructing queries. Even though this only affects few repositories (I've heard of one legacy connector to run into this problem), it would be good to add the proper escaping.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-714) TCK: Test root path not escaped when
used in XPath queries
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662307#action_12662307 ]
Marcel Reutegger commented on JCR-714:
--------------------------------------
We had a similar issue with the ISO8601 class. Instead of introducing a dependency, we copied the class. I don't particularly like that, so I'm OK with the new dependency. Once jackrabbit-jcr-tests depends on jackrabbit-jcr-commons we should remove the class ISO8601 and use the one from the commons module.
> TCK: Test root path not escaped when used in XPath queries
> ----------------------------------------------------------
>
> Key: JCR-714
> URL: https://issues.apache.org/jira/browse/JCR-714
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr-tests
> Reporter: Jukka Zitting
> Priority: Minor
> Attachments: JCR-714.patch
>
>
> A repository implementation might use a test root path that contains names that need _xXXXX_ escaping when used in XPath queries. Currently the TCK just uses the test path as-is when constructing queries. Even though this only affects few repositories (I've heard of one legacy connector to run into this problem), it would be good to add the proper escaping.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.