You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/09/16 17:54:00 UTC
[jira] [Commented] (CB-11721) Android InAppBrowser Previous, Next
page history buttons do not change with the state of the content
[ https://issues.apache.org/jira/browse/CB-11721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16616817#comment-16616817 ]
ASF GitHub Bot commented on CB-11721:
-------------------------------------
janpio commented on issue #182: CB-11721 android: InAppBrowser history buttons fix
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/182#issuecomment-421803934
Hey @justforgolly, there seems to be a merge conflict now. Could you maybe fix this? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Android InAppBrowser Previous, Next page history buttons do not change with the state of the content
> ----------------------------------------------------------------------------------------------------
>
> Key: CB-11721
> URL: https://issues.apache.org/jira/browse/CB-11721
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
> Affects Versions: Master
> Environment: Android OS 6.0.1, Cordova CLI 6.3.1, cordova-android 5.2.1, cordova-plugin-inappbrowser 1.4.0
> Reporter: Arjun Thounaojam
> Assignee: Arjun Thounaojam
> Priority: Major
> Labels: android, triaged
> Attachments: InAppBrowserAndroidCurrentHistoryButtons.png, InAppBrowserAndroidImprovedHistoryButtons.png
>
>
> Steps to reproduce:
> 1) Create a simple Cordova Android app with the InAppBrowser plugin pointing to a website. E.g. https://news.google.com
> 2) Navigate back and forth between different pages
> 3) Observe the history buttons on the toolbar
> Expected behavior:
> The Previous / Next arrow buttons should become highlighted or faded based on where in the page history the content is.
> This behavior is standard on most browsers. The iOS InAppBrowser implements it too.
> Observed behavior:
> The Previous / Next buttons remain highlighted regardless of if it's possible to navigate back or forward in the content.
> This was never implemented for Android so wasn't sure if Issue Type should be a Bug or Improvement. Left it at default.
> I have a potential implementation. Will fork repo and trigger a pull request soon.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org