You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/24 15:18:36 UTC

[GitHub] [flink-kubernetes-operator] tisonkun commented on a diff in pull request #243: [FLINK-27746] Flink kubernetes operator docker image could not build with source release

tisonkun commented on code in PR #243:
URL: https://github.com/apache/flink-kubernetes-operator/pull/243#discussion_r880649631


##########
Dockerfile:
##########
@@ -36,7 +36,7 @@ COPY $DOCS_DIR/pom.xml ./$DOCS_DIR/
 COPY $OPERATOR_DIR/src ./$OPERATOR_DIR/src
 COPY $WEBHOOK_DIR/src ./$WEBHOOK_DIR/src
 
-COPY .git ./.git
+COPY *.git ./.git

Review Comment:
   I'm unsure whether this line can possibly pollute unexpected files. At least we should add a comment about this tricky - it's a workaround since Dockerfile doesn't support conditional copy directly. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org