You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/04/22 19:50:06 UTC
[GitHub] [incubator-druid] gianm commented on issue #7206: Add the
pull-request template
gianm commented on issue #7206: Add the pull-request template
URL: https://github.com/apache/incubator-druid/pull/7206#issuecomment-485529475
A broad question: is the intent of this PR template to put our current practices into writing, or to define a new set of expected practices? I'm asking because there are a lot of things this template asks for that we do not currently always ask for on every PR.
If the intent is to put current practices into writing, I think we should make that clear by calling out what things are required and what are more like suggestions for gold-standard best practices (but, ultimately, not necessarily required).
If the intent is to define a new set of expected practices, that should _also_ be made clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org