You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pdfbox.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2016/05/20 10:46:12 UTC

[jira] [Commented] (PDFBOX-3355) PDPageLabels.getLabelsByPageIndices() returns Uppercase letters for style a

    [ https://issues.apache.org/jira/browse/PDFBOX-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15293154#comment-15293154 ] 

ASF subversion and git services commented on PDFBOX-3355:
---------------------------------------------------------

Commit 1744696 from [~tilman] in branch 'pdfbox/branches/1.8'
[ https://svn.apache.org/r1744696 ]

PDFBOX-3355: makeLetterLabel should return lower case like makeRomanLabel to fix bug reported by Carlos Cabral

> PDPageLabels.getLabelsByPageIndices() returns Uppercase letters for style a
> ---------------------------------------------------------------------------
>
>                 Key: PDFBOX-3355
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-3355
>             Project: PDFBox
>          Issue Type: Bug
>          Components: PDModel
>    Affects Versions: 2.0.1
>         Environment: Windows Computer
>            Reporter: Carlos Cabral
>            Priority: Trivial
>              Labels: easyfix
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> For the style 'a' the Method getLabelsByPageIndices returns uppercase due to the method LabelGenerator.makeLetterLabel always returns uppercase. Then the method LabelGenerator.getNumber shoule be changed from:
> ##################################################
> } else if (PDPageLabelRange.STYLE_LETTERS_LOWER.equals(style)) {
>     return makeLetterLabel(pageIndex);
> } else if (PDPageLabelRange.STYLE_LETTERS_UPPER.equals(style)) {
>     return makeLetterLabel(pageIndex).toUpperCase();
> }
> ##################################################
> to: 
> ##################################################
> } else if (PDPageLabelRange.STYLE_LETTERS_LOWER.equals(style)) {
>     return makeLetterLabel(pageIndex).toLowerCase();
> } else if (PDPageLabelRange.STYLE_LETTERS_UPPER.equals(style)) {
>     return makeLetterLabel(pageIndex);
> }
> ##################################################



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org