[jira] [Commented] (SENTRY-6) Use one policy editor exclusively in all the end to end tests

["Sravya Tirukkovalur (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SENTRY-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757844#comment-13757844 ] 

Sravya Tirukkovalur commented on SENTRY-6:
------------------------------------------

Looks like PolicyFile Class is written specifically for tests, thanks [~brocknoland] for pointing it out. 
                
> Use one policy editor exclusively in all the end to end tests
> -------------------------------------------------------------
>
>                 Key: SENTRY-6
>                 URL: https://issues.apache.org/jira/browse/SENTRY-6
>             Project: Sentry
>          Issue Type: Improvement
>            Reporter: Sravya Tirukkovalur
>            Assignee: Sravya Tirukkovalur
>
> We are using multiple policy editors in the tests. It would be nice to consolidate the usage and just use one exclusively going forward.
> I +1 to PolicyFileEditor, especially as it naturally fits when we want to handle both hadoop groups and local groups in our end to end tests. Something like: 
> {noformat}
> public void addPolicy(String line, String cat) throws Exception {
>     if(hiveServer2Type.equals("UnmanagedHiveServer2") && cat.equals("users")){
>       OSGroups.addMapping(line);
>     }else{
>     //add line to policy file
>     }
>     ...
> {noformat}
> Please let me know if any other Policy File Editors have any advantages over it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira