You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/02/08 08:12:44 UTC

[GitHub] [iotdb] JerryZhangZZY opened a new pull request #5018: [IOTDB-2512]Replaced some static variables with TSDataType.toString

JerryZhangZZY opened a new pull request #5018:
URL: https://github.com/apache/iotdb/pull/5018


   Replaced Boolean, Double and Float with TSDataType.toString in those 3 classes respectively.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] JerryZhangZZY closed pull request #5018: [IOTDB-2512]Replaced some static variables with TSDataType.toString

Posted by GitBox <gi...@apache.org>.
JerryZhangZZY closed pull request #5018:
URL: https://github.com/apache/iotdb/pull/5018


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #5018: [IOTDB-2512]Replaced some static variables with TSDataType.toString

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #5018:
URL: https://github.com/apache/iotdb/pull/5018#issuecomment-1032310176


   
   [![Coverage Status](https://coveralls.io/builds/46324381/badge)](https://coveralls.io/builds/46324381)
   
   Coverage decreased (-0.02%) to 67.728% when pulling **26e3e008093c13e27167adaf0e92d649f84ff5f5 on JerryZhangZZY:IOTDB-2512** into **5767587be65982056e87f0a08552601f4b8d0583 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #5018: [IOTDB-2512]Replaced some static variables with TSDataType.toString

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #5018:
URL: https://github.com/apache/iotdb/pull/5018#issuecomment-1032310176


   
   [![Coverage Status](https://coveralls.io/builds/46323532/badge)](https://coveralls.io/builds/46323532)
   
   Coverage increased (+0.01%) to 67.759% when pulling **26e3e008093c13e27167adaf0e92d649f84ff5f5 on JerryZhangZZY:IOTDB-2512** into **5767587be65982056e87f0a08552601f4b8d0583 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou merged pull request #5018: [IOTDB-2512]Replaced some static variables with TSDataType.toString

Posted by GitBox <gi...@apache.org>.
HTHou merged pull request #5018:
URL: https://github.com/apache/iotdb/pull/5018


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] hoho1221 commented on pull request #5018: [IOTDB-2512]Replaced some static variables with TSDataType.toString

Posted by GitBox <gi...@apache.org>.
hoho1221 commented on pull request #5018:
URL: https://github.com/apache/iotdb/pull/5018#issuecomment-1033561472


   why not just remove `abstract` for these methods in `Statistics` class, and add default implementations `throw StatisticsClassException(String.format(STATS_UNSUPPORTED_MSG, getType(), "***"))`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] JerryZhangZZY closed pull request #5018: [IOTDB-2512]fix

Posted by GitBox <gi...@apache.org>.
JerryZhangZZY closed pull request #5018:
URL: https://github.com/apache/iotdb/pull/5018


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #5018: [IOTDB-2512]Replaced some static variables with TSDataType.toString

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #5018:
URL: https://github.com/apache/iotdb/pull/5018#issuecomment-1032310176


   
   [![Coverage Status](https://coveralls.io/builds/46324668/badge)](https://coveralls.io/builds/46324668)
   
   Coverage increased (+0.04%) to 67.783% when pulling **26e3e008093c13e27167adaf0e92d649f84ff5f5 on JerryZhangZZY:IOTDB-2512** into **5767587be65982056e87f0a08552601f4b8d0583 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] JerryZhangZZY commented on pull request #5018: [IOTDB-2512]Replaced some static variables with TSDataType.toString

Posted by GitBox <gi...@apache.org>.
JerryZhangZZY commented on pull request #5018:
URL: https://github.com/apache/iotdb/pull/5018#issuecomment-1034418427


   Good idea, thanks for your suggestion!
   
   从 Windows 版邮件发送
   
   发件人: Changqi
   发送时间: 2022年2月9日 下午 5:41
   收件人: apache/iotdb
   抄送: Zhang Zeyu; State change
   主题: Re: [apache/iotdb] [IOTDB-2512]Replaced some static variables withTSDataType.toString (PR #5018)
   
   why not just remove abstract for these methods in Statistics class, and add default implementations throw StatisticsClassException(String.format(STATS_UNSUPPORTED_MSG, getType(), "***"))
   —
   Reply to this email directly, view it on GitHub, or unsubscribe.
   Triage notifications on the go with GitHub Mobile for iOS or Android. 
   You are receiving this because you modified the open/close state.Message ID: ***@***.***>
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls commented on pull request #5018: [IOTDB-2512]Replaced some static variables with TSDataType.toString

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5018:
URL: https://github.com/apache/iotdb/pull/5018#issuecomment-1032310176


   
   [![Coverage Status](https://coveralls.io/builds/46321908/badge)](https://coveralls.io/builds/46321908)
   
   Coverage increased (+0.01%) to 67.76% when pulling **4a64762b52efae5e6344172412ea72684051b9b3 on JerryZhangZZY:IOTDB-2512** into **5767587be65982056e87f0a08552601f4b8d0583 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org