You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/01/19 10:43:57 UTC

[GitHub] [incubator-seatunnel] wu-sheng opened a new issue #1100: [License Issue] Please update your source codes' license

wu-sheng opened a new issue #1100:
URL: https://github.com/apache/incubator-seatunnel/issues/1100


   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-seatunnel/issues?q=is%3Aissue+label%3A%22bug%22) and found no similar issues.
   
   
   ### What happened
   
   I accidentally noticed this PR, https://github.com/apache/incubator-seatunnel/pull/912/files#diff-a0275ef336fd0cf14c3d4c026ce3e918301dc0cf7b2663fbf484d9cff5288bd2, which carried the dependency license check script into your source codes. And the same style of `known-dependencies.txt` file, which was created by SkyWalking.
   
   But you should know, this script is coming(copied) from [Apache SkyWalking](https://github.com/apache/skywalking/blob/master/tools/dependencies/check-LICENSE.sh), which was written by one PMC member. And I noticed this script was not submitted by himself(he still owns this file). This file's owner has reviewed this PR, but I think he missed this. Unless he is the one to submit, the License should be taken care of.
   
   So, you should update the source codes' LICENSE to indicate you have copied it from another project. 
   
   FYI @CalvinKirs @zhongjiajie
   
   
   ### SeaTunnel Version
   
   The dev branch
   
   ### SeaTunnel Config
   
   ```conf
   No need.
   ```
   
   
   ### Running Command
   
   ```shell
   No need.
   ```
   
   
   ### Error Exception
   
   ```log
   No need.
   ```
   
   
   ### Flink or Spark Version
   
   _No response_
   
   ### Java or Scala Version
   
   _No response_
   
   ### Screenshots
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel] zhongjiajie closed issue #1100: [License Issue] Please update your source codes' license

Posted by GitBox <gi...@apache.org>.
zhongjiajie closed issue #1100:
URL: https://github.com/apache/incubator-seatunnel/issues/1100


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel] CalvinKirs commented on issue #1100: [License Issue] Please update your source codes' license

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on issue #1100:
URL: https://github.com/apache/incubator-seatunnel/issues/1100#issuecomment-1016312467


   Thanks for the reminder, I'll deal with this asap.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org