You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/27 19:56:59 UTC
[GitHub] [airflow] potiuk opened a new pull request #13329: Re-enables verification of production image
potiuk opened a new pull request #13329:
URL: https://github.com/apache/airflow/pull/13329
Please check only last commit. This commit is based on #13323
The PROD image is now verified by several checks:
* whether all expected providers are installed
* whether pip-check shows no conflicts
* whether imports are working for expected features
Part of #13315
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #13329: Re-enables verification of production image
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #13329:
URL: https://github.com/apache/airflow/pull/13329#discussion_r549168430
##########
File path: scripts/ci/images/ci_verify_prod_image.sh
##########
@@ -51,41 +74,129 @@ function verify_prod_image_has_airflow_and_providers() {
echo
echo "${COLOR_RED_ERROR} Some expected providers are not installed!${COLOR_RESET}"
echo
+ exit 1
+ else
+ echo
+ echo "${COLOR_GREEN_OK} All expected providers installed!${COLOR_RESET}"
+ echo
fi
+ start_end::group_end
}
function verify_prod_image_dependencies() {
-
- echo
- echo "Checking if Airflow dependencies are non-conflicting in ${AIRFLOW_PROD_IMAGE} image."
- echo
+ start_end::group_start "Checking if Airflow dependencies are non-conflicting in ${AIRFLOW_PROD_IMAGE} image."
set +e
- docker run --rm --entrypoint /bin/bash "${AIRFLOW_PROD_IMAGE}" -c 'pip check'
+ run_command_in_image 'pip check'
local res=$?
if [[ ${res} != "0" ]]; then
echo "${COLOR_RED_ERROR} ^^^ Some dependencies are conflicting. See instructions below on how to deal with it. ${COLOR_RESET}"
echo
build_images::inform_about_pip_check "--production "
- # TODO(potiuk) - enable the comment once https://github.com/apache/airflow/pull/12188 is merged
- # exit ${res}
+ exit ${res}
Review comment:
```suggestion
# exit ${res}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13329: Re-enables verification of production image
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13329:
URL: https://github.com/apache/airflow/pull/13329#issuecomment-751524625
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13329: Re-enables verification of production image
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13329:
URL: https://github.com/apache/airflow/pull/13329#issuecomment-751509523
@mik-laj -> this PR enables the verification of image as we discussed in #13306 . Depending which one will be merged first we wil add ldap verification here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #13329: Re-enables verification of production image
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #13329:
URL: https://github.com/apache/airflow/pull/13329#discussion_r549168430
##########
File path: scripts/ci/images/ci_verify_prod_image.sh
##########
@@ -51,41 +74,129 @@ function verify_prod_image_has_airflow_and_providers() {
echo
echo "${COLOR_RED_ERROR} Some expected providers are not installed!${COLOR_RESET}"
echo
+ exit 1
+ else
+ echo
+ echo "${COLOR_GREEN_OK} All expected providers installed!${COLOR_RESET}"
+ echo
fi
+ start_end::group_end
}
function verify_prod_image_dependencies() {
-
- echo
- echo "Checking if Airflow dependencies are non-conflicting in ${AIRFLOW_PROD_IMAGE} image."
- echo
+ start_end::group_start "Checking if Airflow dependencies are non-conflicting in ${AIRFLOW_PROD_IMAGE} image."
set +e
- docker run --rm --entrypoint /bin/bash "${AIRFLOW_PROD_IMAGE}" -c 'pip check'
+ run_command_in_image 'pip check'
local res=$?
if [[ ${res} != "0" ]]; then
echo "${COLOR_RED_ERROR} ^^^ Some dependencies are conflicting. See instructions below on how to deal with it. ${COLOR_RESET}"
echo
build_images::inform_about_pip_check "--production "
- # TODO(potiuk) - enable the comment once https://github.com/apache/airflow/pull/12188 is merged
- # exit ${res}
+ exit ${res}
Review comment:
```suggestion
# TODO(potiuk): enable it after merge when we get sqlite in.
# exit ${res}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #13329: Re-enables verification of production image
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #13329:
URL: https://github.com/apache/airflow/pull/13329
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13329: Re-enables verification of production image
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13329:
URL: https://github.com/apache/airflow/pull/13329#issuecomment-751705314
Temporary error. Merging :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org