You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/09/05 21:24:53 UTC
[GitHub] villebro opened a new pull request #5827: Add missing label quotes
to sqla queries
villebro opened a new pull request #5827: Add missing label quotes to sqla queries
URL: https://github.com/apache/incubator-superset/pull/5827
The original PR #5686 was missing a few necessary calls to `db_engine_spec.make_label_compatible()`. I tried to double check the code and test all edge cases that that came to mind to make sure that all remaining columns/labels were handled, but as always testing help would be much appreciated. Call to @HectorLira @minh5 @mmuru for help testing this!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org