You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by cheng xu <ch...@intel.com> on 2015/03/20 07:05:49 UTC

Review Request 32283: HIVE-8817 Create unit test where we insert into an encrypted table and then read from it with pig

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32283/
-----------------------------------------------------------

Review request for hive and Sergio Pena.


Repository: hive-git


Description
-------

Unit test for loading a encrypted HIVE table by pig server


Diffs
-----

  hcatalog/hcatalog-pig-adapter/pom.xml 229fda2 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoaderEncryption.java PRE-CREATION 
  shims/common/src/main/java/org/apache/hadoop/hive/shims/ShimLoader.java f19e3c6 

Diff: https://reviews.apache.org/r/32283/diff/


Testing
-------

Newly added test passed by the following command "mvn test -Phadoop-2 -Dtest=TestHCatLoaderEncryption".


Thanks,

cheng xu


Re: Review Request 32283: HIVE-8817 Create unit test where we insert into an encrypted table and then read from it with pig

Posted by Sergio Pena <se...@cloudera.com>.

> On March 20, 2015, 4:12 p.m., Sergio Pena wrote:
> > Ship It!

Thanks Ferd for this patch.
I did another review, and the code looks good.


- Sergio


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32283/#review77229
-----------------------------------------------------------


On March 20, 2015, 6:05 a.m., cheng xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32283/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 6:05 a.m.)
> 
> 
> Review request for hive and Sergio Pena.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Unit test for loading a encrypted HIVE table by pig server
> 
> 
> Diffs
> -----
> 
>   hcatalog/hcatalog-pig-adapter/pom.xml 229fda2 
>   hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoaderEncryption.java PRE-CREATION 
>   shims/common/src/main/java/org/apache/hadoop/hive/shims/ShimLoader.java f19e3c6 
> 
> Diff: https://reviews.apache.org/r/32283/diff/
> 
> 
> Testing
> -------
> 
> Newly added test passed by the following command "mvn test -Phadoop-2 -Dtest=TestHCatLoaderEncryption".
> 
> 
> Thanks,
> 
> cheng xu
> 
>


Re: Review Request 32283: HIVE-8817 Create unit test where we insert into an encrypted table and then read from it with pig

Posted by Sergio Pena <se...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32283/#review77229
-----------------------------------------------------------

Ship it!


Ship It!

- Sergio Pena


On March 20, 2015, 6:05 a.m., cheng xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32283/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 6:05 a.m.)
> 
> 
> Review request for hive and Sergio Pena.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Unit test for loading a encrypted HIVE table by pig server
> 
> 
> Diffs
> -----
> 
>   hcatalog/hcatalog-pig-adapter/pom.xml 229fda2 
>   hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoaderEncryption.java PRE-CREATION 
>   shims/common/src/main/java/org/apache/hadoop/hive/shims/ShimLoader.java f19e3c6 
> 
> Diff: https://reviews.apache.org/r/32283/diff/
> 
> 
> Testing
> -------
> 
> Newly added test passed by the following command "mvn test -Phadoop-2 -Dtest=TestHCatLoaderEncryption".
> 
> 
> Thanks,
> 
> cheng xu
> 
>