You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "ivanyu (via GitHub)" <gi...@apache.org> on 2023/03/07 07:34:41 UTC

[GitHub] [kafka] ivanyu commented on pull request #13067: KAFKA-14524: Rewrite KafkaMetricsGroup in Java

ivanyu commented on PR #13067:
URL: https://github.com/apache/kafka/pull/13067#issuecomment-1457689418

   Thank you @satishd! I addressed your last comment.
   
   > Please have incremental commits instead of a single squashed/merged commit. This is helpful for reviewers to review the incremental changes done in the PR that address the review comments.
   
   I relied on Github being able to show the diff on force-push, but sure, I'll do incremental commits and can squash before merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org