You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/01 06:35:33 UTC

[GitHub] [tvm] Hzfengsy opened a new pull request #7553: [TensorIR] introduce Block and BlockRealize

Hzfengsy opened a new pull request #7553:
URL: https://github.com/apache/tvm/pull/7553


   I'm happy to start upstream TensorIR from this PR. 
   TensorIR is a new low-level IR with full scheduling support. Each schedule primitive is a transformation from IR to IR. To get more detailed information please refer to the previous RFC: https://discuss.tvm.apache.org/t/rfc-tensorir-a-schedulable-ir-for-tvm/7872
   
   Since this project is large, we'd like to upstreaming with several PRs:
   - Introduce core data structure (this PR)
   - Add tvmscript support for TensorIR data structure
   - Introduce basic schedule state
   - Add schedule primitives one by one
   
   co-authors: @spectrometerHBH @junrushao1994 @tqchen 
   Also, thanks for help from @jinhongyii @MasterJH5574 @vinx13 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen commented on a change in pull request #7553: [TensorIR] introduce Block and BlockRealize

Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #7553:
URL: https://github.com/apache/tvm/pull/7553#discussion_r584992458



##########
File path: python/tvm/tir/stmt.py
##########
@@ -429,6 +433,164 @@ def __init__(self, buffer, bounds, span=None):
         self.__init_handle_by_constructor__(_ffi_api.Prefetch, buffer, bounds, span)
 
 
+@tvm._ffi.register_object("tir.BufferRegion")
+class BufferRegion(Object):
+    """BufferRegion node.

Review comment:
       I agree some comments might be useful, however given the existing nodes are documented as they are, we might want to do it as a followup(and move some comments from c++)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] comaniac merged pull request #7553: [TensorIR] introduce Block and BlockRealize

Posted by GitBox <gi...@apache.org>.
comaniac merged pull request #7553:
URL: https://github.com/apache/tvm/pull/7553


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen commented on pull request #7553: [TensorIR] introduce Block and BlockRealize

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #7553:
URL: https://github.com/apache/tvm/pull/7553#issuecomment-789727928


   Happy to discuss naming a bit further, however. This particular case, this is indeed a match instead of a simple alias, and we do not plan to introduce the concept of alias/view into the IR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] comaniac commented on pull request #7553: [TensorIR] introduce Block and BlockRealize

Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #7553:
URL: https://github.com/apache/tvm/pull/7553#issuecomment-788277498


   Thanks @Hzfengsy @MasterJH5574 @jinhongyii @tkonolige @junrushao1994 @vinx13  @tqchen 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tkonolige commented on a change in pull request #7553: [TensorIR] introduce Block and BlockRealize

Posted by GitBox <gi...@apache.org>.
tkonolige commented on a change in pull request #7553:
URL: https://github.com/apache/tvm/pull/7553#discussion_r584857735



##########
File path: python/tvm/tir/stmt.py
##########
@@ -429,6 +433,164 @@ def __init__(self, buffer, bounds, span=None):
         self.__init_handle_by_constructor__(_ffi_api.Prefetch, buffer, bounds, span)
 
 
+@tvm._ffi.register_object("tir.BufferRegion")
+class BufferRegion(Object):
+    """BufferRegion node.

Review comment:
       It might be worthwhile to add some more documentation to these objects.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao1994 commented on pull request #7553: [TensorIR] introduce Block and BlockRealize

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #7553:
URL: https://github.com/apache/tvm/pull/7553#issuecomment-789458683


   @jroesch and I thought a bit about the class name `MatchBufferRegion`, which (as we all know) is a bit confusing. We might want to think about potential alternatives, like:
   - AliasBufferAtRegion
   - BufferRegionAlias
   - AliasAt
   - etc
   
   Perhaps we should keep the PR open for like one more day after we approve the PR for more discussion?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org