You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/08/27 14:51:35 UTC

Review Request 37842: Stack meta for JDK support on back-end

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37842/
-----------------------------------------------------------

Review request for Ambari, Andrew Onischuk and Vitalyi Brodetskyi.


Bugs: AMBARI-12902
    https://issues.apache.org/jira/browse/AMBARI-12902


Repository: ambari


Description
-------

Ambari is adding support for JDK 1.8 but not all stacks support JDK 1.8 In the case where a user runs ambari-server setup and select JDK #1 for JDK 1.8, and then during install wizard, selects HDP <=2.2, the user should be warned.
Add meta info to stack to indicate supported JDKs, and warn user in Install Wizard if attempting to install a Stack with an incompatible JDK.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java e0dbe2c 
  ambari-server/src/main/java/org/apache/ambari/server/controller/StackVersionResponse.java 005b8a1 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java adc3a45 
  ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 2df6e04 
  ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 2aa89cc 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/StackMetainfoXml.java 55b1b9b 
  ambari-server/src/main/resources/stacks/HDP/2.0/metainfo.xml 352b8d4 
  ambari-server/src/main/resources/stacks/HDP/2.1/metainfo.xml 3c7f87d 
  ambari-server/src/main/resources/stacks/HDP/2.2/metainfo.xml 0be6cb6 
  ambari-server/src/main/resources/stacks/HDP/2.3/metainfo.xml d04b44b 
  ambari-server/src/main/resources/stacks/HDP/2.4/metainfo.xml fbc1079 

Diff: https://reviews.apache.org/r/37842/diff/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 37842: Stack meta for JDK support on back-end

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37842/#review96679
-----------------------------------------------------------

Ship it!


Ship It!

- Andrew Onischuk


On Aug. 27, 2015, 12:51 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37842/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2015, 12:51 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-12902
>     https://issues.apache.org/jira/browse/AMBARI-12902
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari is adding support for JDK 1.8 but not all stacks support JDK 1.8 In the case where a user runs ambari-server setup and select JDK #1 for JDK 1.8, and then during install wizard, selects HDP <=2.2, the user should be warned.
> Add meta info to stack to indicate supported JDKs, and warn user in Install Wizard if attempting to install a Stack with an incompatible JDK.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java e0dbe2c 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/StackVersionResponse.java 005b8a1 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java adc3a45 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 2df6e04 
>   ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 2aa89cc 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/StackMetainfoXml.java 55b1b9b 
>   ambari-server/src/main/resources/stacks/HDP/2.0/metainfo.xml 352b8d4 
>   ambari-server/src/main/resources/stacks/HDP/2.1/metainfo.xml 3c7f87d 
>   ambari-server/src/main/resources/stacks/HDP/2.2/metainfo.xml 0be6cb6 
>   ambari-server/src/main/resources/stacks/HDP/2.3/metainfo.xml d04b44b 
>   ambari-server/src/main/resources/stacks/HDP/2.4/metainfo.xml fbc1079 
> 
> Diff: https://reviews.apache.org/r/37842/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>