Review request for CB-5579

[Leyonh W <le...@gmail.com>]

Hi,

Can someone review the request ? Thanks in advance.

https://github.com/apache/cordova-plugman/pull/37

Cheers,
Liyong

Re: Review request for CB-5579

[Andrew Grieve <ag...@chromium.org>]

Thanks for the added explanation. I've merged in your change and closed the
JIRA issue.


On Mon, Dec 9, 2013 at 10:22 PM, Leyonh <le...@gmail.com> wrote:

> I have just signed and submitted CLA to secretary@apache.org.
>
> @Shazron I have already included the pull request in JIRA ticket CB-5579.
> Will you get notifications for any updates to JIRA tickets ? It seems to me
> that there are many JIRA tickets are left opened and unassigned.
>
> @Andrew
> According to plugman documentation, plugman should allow customising the
> location of a project's www directory via --www parameter.
> 'plugman install --www <custom_www>' should generate cordova_plugins.json
> file in custom_www directory. This is not the case now.
>
> The steps to reproduce it are also stated in the JIRA ticket.
>
>
>
>
>
> On Tue, Dec 10, 2013 at 10:52 AM, Andrew Grieve <agrieve@chromium.org
> >wrote:
>
> > Liyong, some context as to why you'd like to make this change would be
> nice
> > (what use-case does this address). Doing so will help reviewers get
> excited
> > about your change.
> >
> > Also - you'll need to sign Apache's Contributor Agreement:
> > http://www.apache.org/licenses/#clas (can be done online).
> >
> >
> > On Mon, Dec 9, 2013 at 6:18 PM, Shazron <sh...@gmail.com> wrote:
> >
> > > It's best also to file an issue at http://issues.cordova.io and
> include
> > > the
> > > patch:
> > >
> > >
> >
> https://github.com/leyonh/cordova-plugman/commit/42ee27d1439bb676ea0c60fed46f9dd28e9d9e92.patch
> > >
> > > That might get more visibility - the team doesn't get emails for pull
> > > requests from Github (yet).
> > >
> > >
> > > On Sun, Dec 8, 2013 at 7:30 PM, Leyonh W <le...@gmail.com> wrote:
> > >
> > > > Hi,
> > > >
> > > > Can someone review the request ? Thanks in advance.
> > > >
> > > > https://github.com/apache/cordova-plugman/pull/37
> > > >
> > > > Cheers,
> > > > Liyong
> > > >
> > >
> >
>

Re: Review request for CB-5579

[Leyonh <le...@gmail.com>]

I have just signed and submitted CLA to secretary@apache.org.

@Shazron I have already included the pull request in JIRA ticket CB-5579.
Will you get notifications for any updates to JIRA tickets ? It seems to me
that there are many JIRA tickets are left opened and unassigned.

@Andrew
According to plugman documentation, plugman should allow customising the
location of a project's www directory via --www parameter.
'plugman install --www <custom_www>' should generate cordova_plugins.json
file in custom_www directory. This is not the case now.

The steps to reproduce it are also stated in the JIRA ticket.





On Tue, Dec 10, 2013 at 10:52 AM, Andrew Grieve <ag...@chromium.org>wrote:

> Liyong, some context as to why you'd like to make this change would be nice
> (what use-case does this address). Doing so will help reviewers get excited
> about your change.
>
> Also - you'll need to sign Apache's Contributor Agreement:
> http://www.apache.org/licenses/#clas (can be done online).
>
>
> On Mon, Dec 9, 2013 at 6:18 PM, Shazron <sh...@gmail.com> wrote:
>
> > It's best also to file an issue at http://issues.cordova.io and include
> > the
> > patch:
> >
> >
> https://github.com/leyonh/cordova-plugman/commit/42ee27d1439bb676ea0c60fed46f9dd28e9d9e92.patch
> >
> > That might get more visibility - the team doesn't get emails for pull
> > requests from Github (yet).
> >
> >
> > On Sun, Dec 8, 2013 at 7:30 PM, Leyonh W <le...@gmail.com> wrote:
> >
> > > Hi,
> > >
> > > Can someone review the request ? Thanks in advance.
> > >
> > > https://github.com/apache/cordova-plugman/pull/37
> > >
> > > Cheers,
> > > Liyong
> > >
> >
>

Re: Review request for CB-5579

[Andrew Grieve <ag...@chromium.org>]

Liyong, some context as to why you'd like to make this change would be nice
(what use-case does this address). Doing so will help reviewers get excited
about your change.

Also - you'll need to sign Apache's Contributor Agreement:
http://www.apache.org/licenses/#clas (can be done online).


On Mon, Dec 9, 2013 at 6:18 PM, Shazron <sh...@gmail.com> wrote:

> It's best also to file an issue at http://issues.cordova.io and include
> the
> patch:
>
> https://github.com/leyonh/cordova-plugman/commit/42ee27d1439bb676ea0c60fed46f9dd28e9d9e92.patch
>
> That might get more visibility - the team doesn't get emails for pull
> requests from Github (yet).
>
>
> On Sun, Dec 8, 2013 at 7:30 PM, Leyonh W <le...@gmail.com> wrote:
>
> > Hi,
> >
> > Can someone review the request ? Thanks in advance.
> >
> > https://github.com/apache/cordova-plugman/pull/37
> >
> > Cheers,
> > Liyong
> >
>

Re: Review request for CB-5579

[Shazron <sh...@gmail.com>]

It's best also to file an issue at http://issues.cordova.io and include the
patch:
https://github.com/leyonh/cordova-plugman/commit/42ee27d1439bb676ea0c60fed46f9dd28e9d9e92.patch

That might get more visibility - the team doesn't get emails for pull
requests from Github (yet).


On Sun, Dec 8, 2013 at 7:30 PM, Leyonh W <le...@gmail.com> wrote:

> Hi,
>
> Can someone review the request ? Thanks in advance.
>
> https://github.com/apache/cordova-plugman/pull/37
>
> Cheers,
> Liyong
>