You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2017/05/16 11:08:31 UTC

[GitHub] spark issue #17991: [SPARK-20757][DOC][CORE]Spark timeout several small opti...

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/17991
  
    - Please squash your commits
    - It's not clear to me that `spark.storage.blockManagerSlaveTimeoutMs` is supposed to be documented -- why do you think so?
    - I don't see what the problem is with the default value. It's 120s as documented.
    - Removing spark.rpc.askTimeout looks incorrect
    
    There are problems with almost all of this, so I'd ask that you close this PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org