[GitHub] [incubator-zipkin] jcchavezs commented on issue #2615: Fontawesome is loaded from CDN, so Zipkin Lens doesn't work well offline

[GitBox <gi...@apache.org>]

jcchavezs commented on issue #2615: Fontawesome is loaded from CDN, so Zipkin Lens doesn't work well offline
URL: https://github.com/apache/incubator-zipkin/issues/2615#issuecomment-495981504
 
 
   Ping @tacigar
   
   fre. 24. mai 2019, 20:16 skrev Pete Woods <no...@github.com>:
   
   > Describe the Bug
   >
   > index.html directly refers to fontawesome via CDN
   > Steps to Reproduce
   >
   > Steps to reproduce the behavior:
   > Expected Behaviour
   >
   > Fontawesome should be an NPM dependency, and packed with WebPack. I would
   > also recommend using Create React App, rather than doing all the build
   > script stuff yourselves. It's much easier, IMO!
   >
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-zipkin/issues/2615?email_source=notifications&email_token=AAXOYAU2LTRICFA65ZBI6MTPXAWHNA5CNFSM4HPRV222YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GVYONWQ>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/AAXOYARBRBYRNSHZ7ITNNKLPXAWHNANCNFSM4HPRV22Q>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services