You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/02/10 22:15:24 UTC
Re: Review Request 43407: CMake: Force GMock and libevent to build
and link statically.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43407/
-----------------------------------------------------------
(Updated Feb. 10, 2016, 9:15 p.m.)
Review request for mesos, Joris Van Remoortere and Michael Park.
Summary (updated)
-----------------
CMake: Force GMock and libevent to build and link statically.
Repository: mesos
Description
-------
CMake: Force GMock to build and link statically.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/CMakeLists.txt 9b61376ea6aad304607c20c9823d9ef19013eca0
Diff: https://reviews.apache.org/r/43407/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 43407: CMake: Force GMock and libevent to build
and link statically.
Posted by Alex Clemmer <cl...@gmail.com>.
> On Feb. 11, 2016, 9:31 p.m., M Lawindi wrote:
> > 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 182
> > <https://reviews.apache.org/r/43407/diff/3/?file=1239945#file1239945line182>
> >
> > Fix spaces/tabs
Lawindi and I talked on Slack, and concluded there isn't a tabs issue after all. But, I will break this up so it fits in 80 character lines.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43407/#review118923
-----------------------------------------------------------
On Feb. 18, 2016, 12:59 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43407/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 12:59 a.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Force GMock to build and link statically.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/CMakeLists.txt 9b61376ea6aad304607c20c9823d9ef19013eca0
> 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673
>
> Diff: https://reviews.apache.org/r/43407/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 43407: CMake: Force GMock and libevent to build
and link statically.
Posted by M Lawindi <ml...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43407/#review118923
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
3rdparty/libprocess/3rdparty/CMakeLists.txt (line 182)
<https://reviews.apache.org/r/43407/#comment180235>
Fix spaces/tabs
- M Lawindi
On Feb. 10, 2016, 11:36 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43407/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 11:36 p.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Force GMock to build and link statically.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/CMakeLists.txt 9b61376ea6aad304607c20c9823d9ef19013eca0
>
> Diff: https://reviews.apache.org/r/43407/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 43407: CMake: Force GMock and libevent to build
and link statically.
Posted by Yi Sun <yi...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43407/#review119092
-----------------------------------------------------------
Ship it!
Ship It!
- Yi Sun
On Feb. 10, 2016, 11:36 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43407/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 11:36 p.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Force GMock to build and link statically.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/CMakeLists.txt 9b61376ea6aad304607c20c9823d9ef19013eca0
>
> Diff: https://reviews.apache.org/r/43407/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 43407: CMake: Force GMock and libevent to build
and link statically.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43407/
-----------------------------------------------------------
(Updated Feb. 26, 2016, 5:59 a.m.)
Review request for mesos, Joris Van Remoortere and Michael Park.
Repository: mesos
Description
-------
CMake: Force GMock to build and link statically.
Diffs
-----
3rdparty/libprocess/3rdparty/CMakeLists.txt 9b61376ea6aad304607c20c9823d9ef19013eca0
3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673
Diff: https://reviews.apache.org/r/43407/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 43407: CMake: Force GMock and libevent to build
and link statically.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43407/#review120601
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Feb. 24, 2016, 10:59 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43407/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2016, 10:59 p.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Force GMock to build and link statically.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/CMakeLists.txt 9b61376ea6aad304607c20c9823d9ef19013eca0
> 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673
>
> Diff: https://reviews.apache.org/r/43407/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 43407: CMake: Force GMock and libevent to build
and link statically.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43407/
-----------------------------------------------------------
(Updated Feb. 24, 2016, 10:59 p.m.)
Review request for mesos, Joris Van Remoortere and Michael Park.
Repository: mesos
Description
-------
CMake: Force GMock to build and link statically.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/CMakeLists.txt 9b61376ea6aad304607c20c9823d9ef19013eca0
3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673
Diff: https://reviews.apache.org/r/43407/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 43407: CMake: Force GMock and libevent to build
and link statically.
Posted by Alex Naparu <al...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43407/#review119925
-----------------------------------------------------------
Ship it!
Ship It!
- Alex Naparu
On Feb. 18, 2016, 12:59 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43407/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 12:59 a.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Force GMock to build and link statically.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/CMakeLists.txt 9b61376ea6aad304607c20c9823d9ef19013eca0
> 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673
>
> Diff: https://reviews.apache.org/r/43407/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 43407: CMake: Force GMock and libevent to build
and link statically.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43407/
-----------------------------------------------------------
(Updated Feb. 18, 2016, 12:59 a.m.)
Review request for mesos, Joris Van Remoortere and Michael Park.
Repository: mesos
Description
-------
CMake: Force GMock to build and link statically.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/CMakeLists.txt 9b61376ea6aad304607c20c9823d9ef19013eca0
3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673
Diff: https://reviews.apache.org/r/43407/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 43407: CMake: Force GMock and libevent to build
and link statically.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43407/
-----------------------------------------------------------
(Updated Feb. 10, 2016, 11:36 p.m.)
Review request for mesos, Joris Van Remoortere and Michael Park.
Repository: mesos
Description
-------
CMake: Force GMock to build and link statically.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/CMakeLists.txt 9b61376ea6aad304607c20c9823d9ef19013eca0
Diff: https://reviews.apache.org/r/43407/diff/
Testing
-------
Thanks,
Alex Clemmer