[jira] [Commented] (RATIS-1376) Improve the used memory

["Tsz-wo Sze (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RATIS-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342519#comment-17342519 ] 

Tsz-wo Sze commented on RATIS-1376:
-----------------------------------

The sliding window has to cache all the outstanding requests so that it can retry non-acked the requests.  Similarly, HDFS pipeline has a data queue which also caches all the outstanding requests.

We probably should limit the total size of the outstanding requests in the sliding window.

> Improve the used memory
> -----------------------
>
>                 Key: RATIS-1376
>                 URL: https://issues.apache.org/jira/browse/RATIS-1376
>             Project: Ratis
>          Issue Type: Sub-task
>            Reporter: runzhiwang
>            Priority: Major
>         Attachments: screenshot-1.png
>
>
> [~szetszwo] I find the main used memory caused by SlidingWindow#Client#requests, because when send DataStreamWindowRequest with data, SlidingWindow#Client#requests will hold DataStreamWindowRequest until receive reply. Because DataStreamWindowRequest has data, so the memory used a lot. Still do not know how to improve it.  Not sure whether SlidingWindow is necessary.
>  !screenshot-1.png! 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)