You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by sraghunandan <gi...@git.apache.org> on 2017/04/21 13:12:05 UTC
[GitHub] incubator-carbondata pull request #836: [CARBONDATA-970] getSplits() from ca...
GitHub user sraghunandan opened a pull request:
https://github.com/apache/incubator-carbondata/pull/836
[CARBONDATA-970] getSplits() from carbonScanRDD not ignoring the blocks which are cleared using clean files DDL
problem: After clean files DDL is run, the blocks which are deleted are also getting in getSplits() of CarbonScanRDD.scala
Solution: when the segments index map is created in carbonInputFormat.scala , get only the valid tasks which contain the valid blocks
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sraghunandan/incubator-carbondata CARBONDATA-970_fixed_failures
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/836.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #836
----
commit 2ea757ebcc25fdeda34d9d55197b68df74a91ce2
Author: akashrn5 <ak...@gmail.com>
Date: 2017-04-21T06:41:01Z
getSplits() from carbonScanRDD not ignoring the blocks which are cleared using clean files DDL
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #836: [CARBONDATA-970] getSplits() from ca...
Posted by sraghunandan <gi...@git.apache.org>.
GitHub user sraghunandan reopened a pull request:
https://github.com/apache/incubator-carbondata/pull/836
[CARBONDATA-970] getSplits() from carbonScanRDD not ignoring the blocks which are cleared using clean files DDL
problem: After clean files DDL is run, the blocks which are deleted are also getting in getSplits() of CarbonScanRDD.scala
Solution: when the segments index map is created in carbonInputFormat.scala , get only the valid tasks which contain the valid blocks
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sraghunandan/incubator-carbondata CARBONDATA-970_fixed_failures
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/836.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #836
----
commit 2ea757ebcc25fdeda34d9d55197b68df74a91ce2
Author: akashrn5 <ak...@gmail.com>
Date: 2017-04-21T06:41:01Z
getSplits() from carbonScanRDD not ignoring the blocks which are cleared using clean files DDL
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #836: [CARBONDATA-970] getSplits() from carbonSca...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/836
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #836: [CARBONDATA-970] getSplits() from ca...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/836#discussion_r112735810
--- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
@@ -519,6 +518,14 @@ private boolean isValidBlockBasedOnUpdateDetails(
cacheClient.getSegmentAccessClient().get(tableSegmentUniqueIdentifier);
segmentIndexMap = segmentTaskIndexWrapper.getTaskIdToTableSegmentMap();
}
+ Map<SegmentTaskIndexStore.TaskBucketHolder, AbstractIndex> finalMap =
--- End diff --
Move the finalMap inside if condition.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #836: [CARBONDATA-970] getSplits() from ca...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/836
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #836: [CARBONDATA-970] getSplits() from carbonSca...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/836
Build Failed with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1745/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #836: [CARBONDATA-970] getSplits() from ca...
Posted by sraghunandan <gi...@git.apache.org>.
Github user sraghunandan closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/836
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #836: [CARBONDATA-970] getSplits() from carbonSca...
Posted by akashrn5 <gi...@git.apache.org>.
Github user akashrn5 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/836
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1750/ CI build passed fro spark 1.5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #836: [CARBONDATA-970] getSplits() from carbonSca...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/836
Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1757/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---