You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/03/08 09:13:59 UTC

[GitHub] [pulsar] codelipenghui commented on a change in pull request #6422: [Issue 6283][tiered-storage] Offload policies per namespace

codelipenghui commented on a change in pull request #6422: [Issue 6283][tiered-storage] Offload policies per namespace
URL: https://github.com/apache/pulsar/pull/6422#discussion_r389350333
 
 

 ##########
 File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
 ##########
 @@ -1869,6 +1876,10 @@ private void maybeOffload(CompletableFuture<PositionImpl> finalPromise) {
                 });
 
             long threshold = config.getOffloadAutoTriggerSizeThresholdBytes();
 
 Review comment:
   Can we delete `offloadAutoTriggerSizeThresholdBytes` and `offloadLedgerDeletionLagMs` in  `ManagedLedgerConfig`? since there is `OffloadPolicies` in `LedgerOffloader`.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services