You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/01/18 14:42:07 UTC

[GitHub] maskit commented on issue #1080: ENH: Apply `make format` into C++ client

maskit commented on issue #1080: ENH: Apply `make format` into C++ client
URL: https://github.com/apache/incubator-pulsar/pull/1080#issuecomment-358666550
 
 
   A few notes for reviewers:
   
   This is the latest option list. Some may be not available on 4.0 and/or other versions but it would be a good discussion point if we found any that we want.
   https://clang.llvm.org/docs/ClangFormatStyleOptions.html
   
   Because there are tons of small changes, we might miss some changes that we don't want. Applying too much options at once may cuts your own throat. Maybe some options should be applied later separately.
   
   Finally, please do not start wars. There is no one answer.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services