You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/06 14:15:02 UTC

[GitHub] [kafka] wuYin commented on pull request #10977: MINOR: Reuse hasDefault instead of comparing with NO_DEFAULT_VALUE directly

wuYin commented on pull request #10977:
URL: https://github.com/apache/kafka/pull/10977#issuecomment-874798625


   @showuon Thanks for reply
   This small change is mainly to unify the way to determine if the user has set the default value, both ways are used currently:
   - [ConfigDef.java#L1183](https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java#L1183)
   - [ConfigDef.java#L595](https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java#L595)
   
   I think the code may be more cleaner by using `hasDefault()` uniformly.
   Thank you for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org