You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/08 05:01:49 UTC
[GitHub] [airflow] edwardwang888 opened a new issue #16877: Cleared task instances in manual runs should have borders
edwardwang888 opened a new issue #16877:
URL: https://github.com/apache/airflow/issues/16877
**Description**
Task instances in manual runs do not display with a border, except when the task instance is non-existent (after adding tasks to an existing DAG). Hence, when an _existing_ task instance is cleared, it is displayed without a border, causing it to disappear into the background. To be consistent, existing task instances that are cleared should also be drawn with borders.
Here, `task2a` and `task2b` are newly-added tasks and have `no_status`. They are displayed with borders:
Afterwards, `task1a` and `task1b` are cleared and are drawn without borders:
**Use case / motivation**
To prevent the task instances from disappearing into the background.
**Are you willing to submit a PR?**
Yes, but would need ramp-up time as I am new to front-end.
**Related Issues**
Split from #16824.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] edwardwang888 commented on issue #16877: Cleared task instances in manual runs should have borders
Posted by GitBox <gi...@apache.org>.
edwardwang888 commented on issue #16877:
URL: https://github.com/apache/airflow/issues/16877#issuecomment-904297333
@bbovenzi Sorry for the delay. I have my local development environment setup now, and am playing around with `tree.js`. I will reach out on Slack if I have any questions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on issue #16877: Cleared task instances in manual runs should have borders
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on issue #16877:
URL: https://github.com/apache/airflow/issues/16877#issuecomment-877205750
@edwardwang888 Are you on the airflow slack? I'd be happy to help you get up and running with the frontend :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi edited a comment on issue #16877: Cleared task instances in manual runs should have borders
Posted by GitBox <gi...@apache.org>.
bbovenzi edited a comment on issue #16877:
URL: https://github.com/apache/airflow/issues/16877#issuecomment-877205750
@edwardwang888 Are you on the airflow slack? I'd be happy to help you get up and running with the frontend :)
A good starting point may be to check out the logic for `stroke-width` or `stroke-opacity` in [tree.js](https://github.com/apache/airflow/blob/main/airflow/www/static/js/tree.js)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on issue #16877: Cleared task instances in manual runs should have borders
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on issue #16877:
URL: https://github.com/apache/airflow/issues/16877#issuecomment-913827379
Yeah, you shouldn't have to worry about tests for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] edwardwang888 commented on issue #16877: Cleared task instances in manual runs should have borders
Posted by GitBox <gi...@apache.org>.
edwardwang888 commented on issue #16877:
URL: https://github.com/apache/airflow/issues/16877#issuecomment-878005427
@bbovenzi Sounds good, I will join the Airflow slack! I will be busier for the next week but I will get started on this in a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] edwardwang888 commented on issue #16877: Cleared task instances in manual runs should have borders
Posted by GitBox <gi...@apache.org>.
edwardwang888 commented on issue #16877:
URL: https://github.com/apache/airflow/issues/16877#issuecomment-914925020
@bbovenzi The PR should be ready now. Let me know if you have any comments. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] edwardwang888 edited a comment on issue #16877: Cleared task instances in manual runs should have borders
Posted by GitBox <gi...@apache.org>.
edwardwang888 edited a comment on issue #16877:
URL: https://github.com/apache/airflow/issues/16877#issuecomment-904297333
@bbovenzi Sorry for the delay. I have my local development environment setup now, and am playing around with `tree.js`. I will reach out either here or on Slack if I have any questions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] edwardwang888 edited a comment on issue #16877: Cleared task instances in manual runs should have borders
Posted by GitBox <gi...@apache.org>.
edwardwang888 edited a comment on issue #16877:
URL: https://github.com/apache/airflow/issues/16877#issuecomment-904297333
@bbovenzi Sorry for the delay! I have my local development environment setup now, and am playing around with `tree.js`. I will reach out either here or on Slack if I have any questions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] edwardwang888 commented on issue #16877: Cleared task instances in manual runs should have borders
Posted by GitBox <gi...@apache.org>.
edwardwang888 commented on issue #16877:
URL: https://github.com/apache/airflow/issues/16877#issuecomment-913063488
@bbovenzi Do we usually add tests for cosmetic changes like this one? From a quick skim of the UI tests, it looks like they are mostly focused on the functional aspects of the UI. My changes also did not break any tests, so I am guessing this part of the code is not currently tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi closed issue #16877: Cleared task instances in manual runs should have borders
Posted by GitBox <gi...@apache.org>.
bbovenzi closed issue #16877:
URL: https://github.com/apache/airflow/issues/16877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org