[GitHub] [pinot] apucher commented on a diff in pull request #8578: Add TLS configuration to JDBC driver

[GitBox <gi...@apache.org>]

apucher commented on code in PR #8578:
URL: https://github.com/apache/pinot/pull/8578#discussion_r861267161


##########
pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/utils/DriverUtils.java:
##########
@@ -38,9 +41,31 @@ public class DriverUtils {
   public static final String CONTROLLER = "controller";
   private static final String LIMIT_STATEMENT_REGEX = "\\s(limit)\\s";
 
+  // SSL Properties
+  public static final String KEYSTORE_TYPE = "keystore.type";
+  public static final String KEYSTORE_PATH = "keystore.path";
+  public static final String KEYSTORE_PASSWORD = "keystore.password";
+  public static final String TRUSTSTORE_TYPE = "truststore.type";
+  public static final String TRUSTSTORE_PATH = "truststore.path";
+  public static final String TRUSTSTORE_PASSWORD = "truststore.password";
+
   private DriverUtils() {
   }
 
+  public static SSLContext getSSLContextFromJDBCProps(Properties properties) {

Review Comment:
   @KKcorps should be fine to expand the interface of `TlsUtils` to take properties or maps in addition to pinot configs



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org