You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by "ahaoyao (via GitHub)" <gi...@apache.org> on 2023/05/05 13:27:59 UTC
[GitHub] [linkis] ahaoyao opened a new pull request, #4521: properties values support the Chinese
ahaoyao opened a new pull request, #4521:
URL: https://github.com/apache/linkis/pull/4521
properties values support the Chinese
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [linkis] casionone commented on a diff in pull request #4521: properties values support the Chinese
Posted by "casionone (via GitHub)" <gi...@apache.org>.
casionone commented on code in PR #4521:
URL: https://github.com/apache/linkis/pull/4521#discussion_r1187629438
##########
linkis-commons/linkis-common/src/test/scala/org/apache/linkis/common/conf/BDPConfigurationTest.scala:
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.linkis.common.conf
+
+import org.junit.jupiter.api._
+
+class BDPConfigurationTest {
+
+ @Test private[conf] def testGetOption(): Unit = {
+ Assertions.assertEquals(
+ "properties支持中文",
+ BDPConfiguration
+ .getOption(CommonVars("linkis.jobhistory.error.msg.tip", "properties支持中文(默认)"))
+ .getOrElse("123")
+ )
+
+ Assertions.assertEquals(
+ "properties支持中文(默认)",
+ BDPConfiguration
+ .getOption(CommonVars("linkis.jobhistory.error.msg.tip1", "properties支持中文(默认)"))
+ .getOrElse("123")
+ )
+ }
+
+}
Review Comment:
Prefer to use java
We are now converting scala to java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [linkis] casionone merged pull request #4521: properties values support the Chinese
Posted by "casionone (via GitHub)" <gi...@apache.org>.
casionone merged PR #4521:
URL: https://github.com/apache/linkis/pull/4521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org