You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/07/21 13:50:11 UTC
[GitHub] [bookkeeper] gaozhangmin opened a new pull request, #3416: Fix configuration cannot be leave unset in bk_server.conf
gaozhangmin opened a new pull request, #3416:
URL: https://github.com/apache/bookkeeper/pull/3416
### Motivation
We cannot leave `dbStorage_readAheadCacheBatchSize` `dbStorage_maxThrottleTimeMs` unset like `dbStorage_writeCacheMaxSizeMb`
### Changes
If configuration is not set in bk_server.conf, default value will be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] gaozhangmin closed pull request #3416: Fix configuration cannot be leave unset in bk_server.conf
Posted by GitBox <gi...@apache.org>.
gaozhangmin closed pull request #3416: Fix configuration cannot be leave unset in bk_server.conf
URL: https://github.com/apache/bookkeeper/pull/3416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] gaozhangmin commented on pull request #3416: Fix configuration cannot be leave unset in bk_server.conf
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on PR #3416:
URL: https://github.com/apache/bookkeeper/pull/3416#issuecomment-1193626692
@hangc0276 @dlg99 I will close this pr, Comparing with `dbStorage_writeCacheMaxSizeMb `,it's hard to set a default value in bk_server.conf for it (it use a proportion of direct memory). So it need to be allowed unset.
but dbStorage_readAheadCacheBatchSize and dbStorage_maxThrottleTimeMs we should set a default value in bk_server.conf for then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on pull request #3416: Fix configuration cannot be leave unset in bk_server.conf
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on PR #3416:
URL: https://github.com/apache/bookkeeper/pull/3416#issuecomment-1193441821
> `ServerConfiguration` already has
>
> ```
> public long getLong(String key, long defaultValue)
> ```
>
> and similarly for Int, etc.
>
> why do we need these helper methods (and, therefore, unit tests for them)?
@gaozhangmin Would you please take a look at this comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] dlg99 commented on pull request #3416: Fix configuration cannot be leave unset in bk_server.conf
Posted by GitBox <gi...@apache.org>.
dlg99 commented on PR #3416:
URL: https://github.com/apache/bookkeeper/pull/3416#issuecomment-1191838649
`ServerConfiguration` already has
```
public long getLong(String key, long defaultValue)
```
and similarly for Int, etc.
why do we need these helper methods (and, therefore, unit tests for them)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org