You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "gemmellr (via GitHub)" <gi...@apache.org> on 2023/02/15 18:36:31 UTC

[GitHub] [activemq-artemis] gemmellr commented on a diff in pull request #4363: ARTEMIS-4161 AMQP and OpenWire leaking leaking objects in certain conditions

gemmellr commented on code in PR #4363:
URL: https://github.com/apache/activemq-artemis/pull/4363#discussion_r1107548367


##########
tests/leak-tests/pom.xml:
##########
@@ -0,0 +1,488 @@
+<!--

Review Comment:
   There still appears to be rather a lot kept around that are either unused or superfluous, even besides the MQTT 3 and 5 clients (which if they arent used as it seems, can be dropped added whenever any tests are added that use them).
   
   Most of the dependencies still seem unused or superfluous repetition of transitive deps...e.g various individual netty deps? They seem like they should all be implicit transitively unless the tests are explicitly using netty themslves, which they dont appear to be. Is anything using artemis-ra, artemis-spring-integration, transaction and management specs? Etc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org