You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mcgilman <gi...@git.apache.org> on 2016/07/26 17:09:59 UTC
[GitHub] nifi pull request #725: Addressing issues surrounding Template uploading
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/725
Addressing issues surrounding Template uploading
NIFI-2224:
- Ensuring the template form is reset when the upload template dialog is closed.
NIFI-2175:
- Not submitting the template form is a template isn't choosen.
NIFI-2176:
- Ensuring a template is specified during creation.
NIFI-2223:
- Ensuring templates with the same name cannot be added.
NIFI-2296:
- Updating the tooltip for the upload template browse button.
- Cleaning up un-used parameters to REST endpoints.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcgilman/nifi NIFI-2175
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/725.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #725
----
commit 32a6482662add3d41307661d93de06261054e5ff
Author: Matt Gilman <ma...@gmail.com>
Date: 2016-07-26T15:02:04Z
NIFI-2224:
- Ensuring the template form is reset when the upload template dialog is closed.
NIFI-2175:
- Not submitting the template form is a template isn't choosen.
NIFI-2176:
- Ensuring a template is specified during creation.
NIFI-2223:
- Ensuring templates with the same name cannot be added.
NIFI-2296:
- Updating the tooltip for the upload template browse button.
- Cleaning up un-used parameters to REST endpoints.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #725: Addressing issues surrounding Template uploading
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/725
+1
Visually verified code and did a contrib check build. In both standalone and 3 node secure cluster, I tested all 5 situations and various other checks relating to templates. Thanks @mcgilman, I will merge it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #725: Addressing issues surrounding Template uploading
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/725
Good catch and great suggestion. I've updated the PR accordingly. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #725: Addressing issues surrounding Template uploading
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/725
Empty name template checking appears to only occur as a server side check. This would be a simple client side check to add and would be a nice UX addition.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #725: Addressing issues surrounding Template uploading
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/725
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #725: Addressing issues surrounding Template uploading
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/725
3 node secure cluster testing NIFI-2223, I see "conflict" and not "A template named 'XYZ' already exists."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---