You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2020/11/17 14:49:49 UTC
[GitHub] [systemds] Shafaq-Siddiqi opened a new pull request #1108: [SYSTEMDS-2735] GMM Predict for predicting the clusters of new instances
Shafaq-Siddiqi opened a new pull request #1108:
URL: https://github.com/apache/systemds/pull/1108
Predict method for Gaussian Mixture Model
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] asfgit closed pull request #1108: [SYSTEMDS-2735] GMM Predict for clustering new instances
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1108:
URL: https://github.com/apache/systemds/pull/1108
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] mboehm7 commented on pull request #1108: [SYSTEMDS-2735] GMM Predict for clustering new instances
Posted by GitBox <gi...@apache.org>.
mboehm7 commented on pull request #1108:
URL: https://github.com/apache/systemds/pull/1108#issuecomment-766195637
LGTM - thanks for the patch @Shafaq-Siddiqi. Generally this looks very good. I just renamed the new builtin to gmmPredict for consistency, changed the formatting a bit, added the missing reset of rewrite flags in the test, and disabled the spark tests (as forced spark mode at algorithm level is a bit too much here).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org