You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/29 15:19:06 UTC

[GitHub] [incubator-nuttx] minabeoki commented on a diff in pull request #6178: armv7-a/r: use cps instruction to change cpu mode

minabeoki commented on code in PR #6178:
URL: https://github.com/apache/incubator-nuttx/pull/6178#discussion_r861905633


##########
arch/arm/src/armv7-a/arm_vectors.S:
##########
@@ -171,16 +171,13 @@
 	.type	arm_vectorirq, %function
 
 arm_vectorirq:
-	/* On entry, we are in IRQ mode.  We are free to use the IRQ mode r13
-	 * and r14.
-	 */
+	/* Switch to SYS mode */
 
 #ifdef CONFIG_ARMV7A_DECODEFIQ
-	mov		r13, #(PSR_MODE_SYS | PSR_I_BIT | PSR_F_BIT)
+	cpsid	if, #PSR_MODE_SYS

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org