[PR] Kill the process tree and keep the output on execution timeout [maven-executor]

["slachiewicz (via GitHub)" <gi...@apache.org>]

slachiewicz opened a new pull request, #64:
URL: https://github.com/apache/maven-executor/pull/64

   On timeout the forked executor now destroys the descendants of the started process before the process itself, and throws `ExecutorTimeoutException`, a subclass of `ExecutorException` that carries the output grabbed so far. The message keeps its `Process timeout: ` prefix.
   
   `ProcessHandle` is called by reflection rather than from `src/main/java9`: tests and other exploded class paths load from `target/classes`, where multi-release classes are never used. On Java 8 only the process itself is destroyed, as before.
   
   Fixes #48
   Fixes #58
   
   Verified: with `process.destroyForcibly()` restored, `timeoutDestroysTheProcessTree` fails (the grandchild's heartbeat file grows from 92 to 110 bytes after the exception); with the grabbed output dropped, `timeoutKeepsTheGrabbedOutput` fails.
   
   Not run on Windows, where the started process is the `cmd.exe` running `mvn.cmd`; CI covers it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Kill the process tree and keep the output on execution timeout [maven-executor]

["slachiewicz (via GitHub)" <gi...@apache.org>]

slachiewicz closed pull request #64: Kill the process tree and keep the output on execution timeout
URL: https://github.com/apache/maven-executor/pull/64


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org