[jira] [Commented] (ACE-404) Error in Comparator for sorting artifact recognizer: services are not really sorted depending on their SERVICE_RANKING

["Marcel Offermans (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ACE-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13730772#comment-13730772 ] 

Marcel Offermans commented on ACE-404:
--------------------------------------

That indeed looks like a bug.
Furthermore, I'm not sure if we still need to provide our own comparator for service references. They should be sortable (by rank) by default now.
                
> Error in Comparator for sorting artifact recognizer: services are not really sorted depending on their SERVICE_RANKING
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: ACE-404
>                 URL: https://issues.apache.org/jira/browse/ACE-404
>             Project: ACE
>          Issue Type: Bug
>          Components: Client Repository
>    Affects Versions: 1.0.0
>            Reporter: Wilfried Sibla
>
> ArtifactRepositoryImpl.SERVICE_RANK_COMPARATOR, line 542
> is: rank1 = (rankObject2 == null) ? 0 : ((Integer) rankObject2).intValue();
> must be: rank2 = (rankObject2 == null) ? 0 : ((Integer) rankObject2).intValue();

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira