You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "geido (via GitHub)" <gi...@apache.org> on 2023/03/16 18:24:11 UTC
[GitHub] [superset] geido opened a new pull request, #23400: fix: Select all issue with "Dynamically search all filter values" in FilterBar
geido opened a new pull request, #23400:
URL: https://github.com/apache/superset/pull/23400
### SUMMARY
When the search was conducted using the "Dynamically search all filter values" in FilterBar, the original options got lost and the Select component was selecting all values as a consequence.
This PR fixes that by keeping the initial data in state and merging it with the new options as they are added.
### BEFORE
https://user-images.githubusercontent.com/60598000/225716552-7d95c6ab-e91a-409f-9855-32607c0a38f9.mp4
### AFTER
https://user-images.githubusercontent.com/60598000/225716624-ac60ba1b-355d-4b0e-8a38-7de8040fea76.mp4
### TESTING INSTRUCTIONS
1. In FilterBar add a new filter with the "Dynamically search all filter values"
2. Write a new value
3. Select the value
4. Make sure only the selected value is selected
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #23400: fix: Select all issue with "Dynamically search all filter values" in FilterBar
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23400:
URL: https://github.com/apache/superset/pull/23400#issuecomment-1473731308
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido merged pull request #23400: fix: Select all issue with "Dynamically search all filter values" in FilterBar
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido merged PR #23400:
URL: https://github.com/apache/superset/pull/23400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a diff in pull request #23400: fix: Select all issue with "Dynamically search all filter values" in FilterBar
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on code in PR #23400:
URL: https://github.com/apache/superset/pull/23400#discussion_r1140031918
##########
superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx:
##########
@@ -120,6 +121,7 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) {
}),
[],
);
+ const [initialData, setInitialData] = useState<typeof data>([]);
Review Comment:
Could we explicitly type it as `DataRecord[]`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa commented on pull request #23400: fix: Select all issue with "Dynamically search all filter values" in FilterBar
Posted by "jinghua-qa (via GitHub)" <gi...@apache.org>.
jinghua-qa commented on PR #23400:
URL: https://github.com/apache/superset/pull/23400#issuecomment-1472888109
Test the PR locally, the issue have been fixed. LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23400: fix: Select all issue with "Dynamically search all filter values" in FilterBar
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23400:
URL: https://github.com/apache/superset/pull/23400#issuecomment-1472520352
## [Codecov](https://codecov.io/gh/apache/superset/pull/23400?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23400](https://codecov.io/gh/apache/superset/pull/23400?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1d6d613) into [master](https://codecov.io/gh/apache/superset/commit/870bf6d0b9a9d4feaceac1544bd9eda71b803db5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (870bf6d) will **decrease** coverage by `11.18%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #23400 +/- ##
===========================================
- Coverage 67.58% 56.41% -11.18%
===========================================
Files 1907 1907
Lines 73530 73512 -18
Branches 7980 7977 -3
===========================================
- Hits 49697 41473 -8224
- Misses 21785 29993 +8208
+ Partials 2048 2046 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.76% <ø> (ø)` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `52.68% <ø> (ø)` | |
| python | `59.18% <ø> (-23.12%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `52.48% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23400?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/23400?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `63.33% <ø> (+0.51%)` | :arrow_up: |
... and [301 files with indirect coverage changes](https://codecov.io/gh/apache/superset/pull/23400/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #23400: fix: Select all issue with "Dynamically search all filter values" in FilterBar
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23400:
URL: https://github.com/apache/superset/pull/23400#issuecomment-1472746266
@jinghua-qa Ephemeral environment spinning up at http://34.214.29.212:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa commented on pull request #23400: fix: Select all issue with "Dynamically search all filter values" in FilterBar
Posted by "jinghua-qa (via GitHub)" <gi...@apache.org>.
jinghua-qa commented on PR #23400:
URL: https://github.com/apache/superset/pull/23400#issuecomment-1472744057
/testenv up FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_HORIZONTAL_FILTER_BAR=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org