You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/12/09 16:45:07 UTC
[GitHub] [cordova-plugin-inappbrowser] jcesarmobile opened a new issue #831: plugin doesn't compile on Xcode 10
jcesarmobile opened a new issue #831:
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/831
The plugin engines are set to cordova-ios 4 or greater. Which I think supported Xcode 9 and greater, but latest changes on 4.1.0 of the plugin makes it not compile on Xcode 10 or older because it doesn't understand `defaultWebpagePreferences`
It can be easily be fixed by using `#if __IPHONE_OS_VERSION_MAX_ALLOWED >= 130000` macros around the code, but I've already merged a [breaking change](https://github.com/apache/cordova-plugin-inappbrowser/pull/821).
Should we revert the breaking change and do a patch release with the fix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] jcesarmobile commented on issue #831: plugin doesn't compile on Xcode 10
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on issue #831:
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/831#issuecomment-763765505
closing as won't fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] jcesarmobile closed issue #831: plugin doesn't compile on Xcode 10
Posted by GitBox <gi...@apache.org>.
jcesarmobile closed issue #831:
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/831
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] brodybits commented on issue #831: plugin doesn't compile on Xcode 10
Posted by GitBox <gi...@apache.org>.
brodybits commented on issue #831:
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/831#issuecomment-741909437
I have added the **bug** label, and we should probably make the patch release if we want to be strictly "semver" compliant.
That said, I don't know how many people would be affected, and anyone affected could always pin the old version as a workaround. I suspect that time spent making the patch release could be better spent solving some other issues on Cordova.
> Also, we should be more aggressive bumping the engines
+1
I would favor that we avoid supporting old Xcode versions that are no longer supported by Apple itself, unless they are needed for some other reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org